Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support generic qualifiers for TypeName #115

Merged
merged 1 commit into from
Jan 23, 2024
Merged

Support generic qualifiers for TypeName #115

merged 1 commit into from
Jan 23, 2024

Conversation

kdubb
Copy link
Contributor

@kdubb kdubb commented Jan 23, 2024 •
edited

Allows qualifying a TypeName with a generic qaulifier (some or any).

You qualify a type explicitly or using convenience on TypeName:

val myType = DeclaredTypeName.typeName(".MyType")

// Explicitly
GenericQualifiedTypeName.any(myType) // -> any MyType

// Convenience
myType.qualify(GenericQualifier.Any) // -> any MyType

Fixes #114

@kdubb kdubb mentioned this pull request Jan 23, 2024
Closed
@kdubb kdubb force-pushed the feature/generic-qualify branch 2 times, most recently from 00f4ac4 to 8831113 Compare January 23, 2024 18:19
@kdubb
Support generic qualifiers for TypeName
ebf329c 
Allows qualifying a `TypeName` with a generic qaulifier (`some` or `any`).
@kdubb kdubb merged commit 7e699b8 into main Jan 23, 2024
1 check passed
@kdubb kdubb deleted the feature/generic-qualify branch January 23, 2024 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dnkoutso dnkoutso dnkoutso approved these changes

@oldergod oldergod Awaiting requested review from oldergod

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

How to indicate that a function returns "some TypeName"?
2 participants
@kdubb @dnkoutso