perf: reduce memory usage upon running server tests (#3949)

* perf: reduce memory usage upon running server tests

* perf: plug leaks in server/routes

* perf: plug leaks in server/scripts

* perf: plug leaks in server/policies

* perf: plug leaks in server/models

* perf: plug leaks in server/middlewares

* perf: plug leaks in server/commands

* fix: missing await on db.flush

* perf: plug leaks in server/queues

* chore: remove unused legacy funcs

* fix: await on db.flush

* perf: await on GC to run in between tests

* fix: remove db refs

* fix: revert embeds

* perf: plug leaks in shared/i18n

.jestconfig.json

@@ -15,7 +15,8 @@
         "<rootDir>/server/test/setup.ts"
       ],
       "testEnvironment": "node",
-      "runner": "@getoutline/jest-runner-serial"
+      "runner": "@getoutline/jest-runner-serial",
+      "detectLeaks": true
     },
     {
       "displayName": "app",
@@ -56,6 +57,9 @@
       "setupFiles": [
         "<rootDir>/__mocks__/console.js"
       ],
+      "setupFilesAfterEnv": [
+        "<rootDir>/shared/test/setup.ts"
+      ],
       "testEnvironment": "node"
     },
     {
@@ -79,4 +83,4 @@
       }
     }
   ]
-}
+}

server/commands/accountProvisioner.test.ts

@@ -4,12 +4,14 @@ import { TeamDomain } from "@server/models";
 import Collection from "@server/models/Collection";
 import UserAuthentication from "@server/models/UserAuthentication";
 import { buildUser, buildTeam } from "@server/test/factories";
-import { flushdb, seed } from "@server/test/support";
+import { getTestDatabase, seed } from "@server/test/support";
 import accountProvisioner from "./accountProvisioner";
 
-beforeEach(() => {
-  return flushdb();
-});
+const db = getTestDatabase();
+
+afterAll(db.disconnect);
+
+beforeEach(db.flush);
 
 describe("accountProvisioner", () => {
   const ip = "127.0.0.1";

server/commands/documentImporter.test.ts

@@ -2,11 +2,16 @@ import path from "path";
 import fs from "fs-extra";
 import Attachment from "@server/models/Attachment";
 import { buildUser } from "@server/test/factories";
-import { flushdb } from "@server/test/support";
+import { getTestDatabase } from "@server/test/support";
 import documentImporter from "./documentImporter";
 
 jest.mock("../utils/s3");
-beforeEach(() => flushdb());
+
+const db = getTestDatabase();
+
+afterAll(db.disconnect);
+
+beforeEach(db.flush);
 
 describe("documentImporter", () => {
   const ip = "127.0.0.1";

server/commands/documentMover.test.ts

@@ -5,10 +5,14 @@ import {
   buildCollection,
   buildUser,
 } from "@server/test/factories";
-import { flushdb, seed } from "@server/test/support";
+import { getTestDatabase, seed } from "@server/test/support";
 import documentMover from "./documentMover";
 
-beforeEach(() => flushdb());
+const db = getTestDatabase();
+
+afterAll(db.disconnect);
+
+beforeEach(db.flush);
 
 describe("documentMover", () => {
   const ip = "127.0.0.1";

server/commands/documentPermanentDeleter.test.ts

@@ -1,10 +1,14 @@
 import { subDays } from "date-fns";
 import { Attachment, Document } from "@server/models";
 import { buildAttachment, buildDocument } from "@server/test/factories";
-import { flushdb } from "@server/test/support";
+import { getTestDatabase } from "@server/test/support";
 import documentPermanentDeleter from "./documentPermanentDeleter";
 
-beforeEach(() => flushdb());
+const db = getTestDatabase();
+
+afterAll(db.disconnect);
+
+beforeEach(db.flush);
 
 describe("documentPermanentDeleter", () => {
   it("should destroy documents", async () => {

server/commands/documentUpdater.test.ts

@@ -1,10 +1,14 @@
 import { sequelize } from "@server/database/sequelize";
 import { Event } from "@server/models";
 import { buildDocument, buildUser } from "@server/test/factories";
-import { flushdb } from "@server/test/support";
+import { getTestDatabase } from "@server/test/support";
 import documentUpdater from "./documentUpdater";
 
-beforeEach(() => flushdb());
+const db = getTestDatabase();
+
+afterAll(db.disconnect);
+
+beforeEach(db.flush);
 
 describe("documentUpdater", () => {
   const ip = "127.0.0.1";

server/commands/fileOperationDeleter.test.ts

@@ -1,9 +1,13 @@
 import { FileOperation } from "@server/models";
 import { buildAdmin, buildFileOperation } from "@server/test/factories";
-import { flushdb } from "@server/test/support";
+import { getTestDatabase } from "@server/test/support";
 import fileOperationDeleter from "./fileOperationDeleter";
 
-beforeEach(() => flushdb());
+const db = getTestDatabase();
+
+afterAll(db.disconnect);
+
+beforeEach(db.flush);
 
 describe("fileOperationDeleter", () => {
   const ip = "127.0.0.1";

server/commands/pinCreator.test.ts

@@ -1,9 +1,14 @@
 import { Event } from "@server/models";
 import { buildDocument, buildUser } from "@server/test/factories";
-import { flushdb } from "@server/test/support";
+import { getTestDatabase } from "@server/test/support";
 import pinCreator from "./pinCreator";
 
-beforeEach(() => flushdb());
+const db = getTestDatabase();
+
+afterAll(db.disconnect);
+
+beforeEach(db.flush);
+
 describe("pinCreator", () => {
   const ip = "127.0.0.1";
 

server/commands/pinDestroyer.test.ts

@@ -1,9 +1,14 @@
 import { Pin, Event } from "@server/models";
 import { buildDocument, buildUser } from "@server/test/factories";
-import { flushdb } from "@server/test/support";
+import { getTestDatabase } from "@server/test/support";
 import pinDestroyer from "./pinDestroyer";
 
-beforeEach(() => flushdb());
+const db = getTestDatabase();
+
+afterAll(db.disconnect);
+
+beforeEach(db.flush);
+
 describe("pinCreator", () => {
   const ip = "127.0.0.1";
 

server/commands/revisionCreator.test.ts

@@ -1,9 +1,13 @@
 import { Event } from "@server/models";
 import { buildDocument, buildUser } from "@server/test/factories";
-import { flushdb } from "@server/test/support";
+import { getTestDatabase } from "@server/test/support";
 import revisionCreator from "./revisionCreator";
 
-beforeEach(() => flushdb());
+const db = getTestDatabase();
+
+afterAll(db.disconnect);
+
+beforeEach(db.flush);
 
 describe("revisionCreator", () => {
   const ip = "127.0.0.1";

server/commands/starCreator.test.ts

@@ -1,10 +1,15 @@
 import { sequelize } from "@server/database/sequelize";
 import { Star, Event } from "@server/models";
 import { buildDocument, buildUser } from "@server/test/factories";
-import { flushdb } from "@server/test/support";
+import { getTestDatabase } from "@server/test/support";
 import starCreator from "./starCreator";
 
-beforeEach(() => flushdb());
+const db = getTestDatabase();
+
+afterAll(db.disconnect);
+
+beforeEach(db.flush);
+
 describe("starCreator", () => {
   const ip = "127.0.0.1";
 

server/commands/starDestroyer.test.ts

@@ -1,9 +1,13 @@
 import { Star, Event } from "@server/models";
 import { buildDocument, buildUser } from "@server/test/factories";
-import { flushdb } from "@server/test/support";
+import { getTestDatabase } from "@server/test/support";
 import starDestroyer from "./starDestroyer";
 
-beforeEach(() => flushdb());
+const db = getTestDatabase();
+
+afterAll(db.disconnect);
+
+beforeEach(db.flush);
 
 describe("starDestroyer", () => {
   const ip = "127.0.0.1";

server/commands/starUpdater.test.ts

@@ -1,9 +1,13 @@
 import { Star, Event } from "@server/models";
 import { buildDocument, buildUser } from "@server/test/factories";
-import { flushdb } from "@server/test/support";
+import { getTestDatabase } from "@server/test/support";
 import starUpdater from "./starUpdater";
 
-beforeEach(() => flushdb());
+const db = getTestDatabase();
+
+afterAll(db.disconnect);
+
+beforeEach(db.flush);
 
 describe("starUpdater", () => {
   const ip = "127.0.0.1";

server/commands/teamPermanentDeleter.test.ts

@@ -6,10 +6,14 @@ import {
   buildTeam,
   buildDocument,
 } from "@server/test/factories";
-import { flushdb } from "@server/test/support";
+import { getTestDatabase } from "@server/test/support";
 import teamPermanentDeleter from "./teamPermanentDeleter";
 
-beforeEach(() => flushdb());
+const db = getTestDatabase();
+
+afterAll(db.disconnect);
+
+beforeEach(db.flush);
 
 describe("teamPermanentDeleter", () => {
   it("should destroy related data", async () => {

server/commands/teamProvisioner.test.ts

@@ -1,10 +1,14 @@
 import env from "@server/env";
 import TeamDomain from "@server/models/TeamDomain";
 import { buildTeam, buildUser } from "@server/test/factories";
-import { flushdb } from "@server/test/support";
+import { getTestDatabase } from "@server/test/support";
 import teamProvisioner from "./teamProvisioner";
 
-beforeEach(() => flushdb());
+const db = getTestDatabase();
+
+afterAll(db.disconnect);
+
+beforeEach(db.flush);
 
 describe("teamProvisioner", () => {
   const ip = "127.0.0.1";

server/commands/userDestroyer.test.ts

@@ -1,8 +1,12 @@
 import { buildUser, buildAdmin } from "@server/test/factories";
-import { flushdb } from "@server/test/support";
+import { getTestDatabase } from "@server/test/support";
 import userDestroyer from "./userDestroyer";
 
-beforeEach(() => flushdb());
+const db = getTestDatabase();
+
+afterAll(db.disconnect);
+
+beforeEach(db.flush);
 
 describe("userDestroyer", () => {
   const ip = "127.0.0.1";

server/commands/userInviter.test.ts

@@ -1,8 +1,12 @@
 import { buildUser } from "@server/test/factories";
-import { flushdb } from "@server/test/support";
+import { getTestDatabase } from "@server/test/support";
 import userInviter from "./userInviter";
 
-beforeEach(() => flushdb());
+const db = getTestDatabase();
+
+afterAll(db.disconnect);
+
+beforeEach(db.flush);
 
 describe("userInviter", () => {
   const ip = "127.0.0.1";

server/commands/userProvisioner.test.ts

@@ -1,10 +1,14 @@
 import { v4 as uuidv4 } from "uuid";
 import { TeamDomain } from "@server/models";
 import { buildUser, buildTeam, buildInvite } from "@server/test/factories";
-import { flushdb, seed } from "@server/test/support";
+import { getTestDatabase, seed } from "@server/test/support";
 import userProvisioner from "./userProvisioner";
 
-beforeEach(() => flushdb());
+const db = getTestDatabase();
+
+afterAll(db.disconnect);
+
+beforeEach(db.flush);
 
 describe("userProvisioner", () => {
   const ip = "127.0.0.1";

server/commands/userSuspender.test.ts

@@ -1,9 +1,13 @@
 import GroupUser from "@server/models/GroupUser";
 import { buildGroup, buildAdmin, buildUser } from "@server/test/factories";
-import { flushdb } from "@server/test/support";
+import { getTestDatabase } from "@server/test/support";
 import userSuspender from "./userSuspender";
 
-beforeEach(() => flushdb());
+const db = getTestDatabase();
+
+afterAll(db.disconnect);
+
+beforeEach(db.flush);
 
 describe("userSuspender", () => {
   const ip = "127.0.0.1";

server/middlewares/authentication.test.ts

@@ -1,10 +1,14 @@
 import randomstring from "randomstring";
 import ApiKey from "@server/models/ApiKey";
 import { buildUser, buildTeam } from "@server/test/factories";
-import { flushdb } from "@server/test/support";
+import { getTestDatabase } from "@server/test/support";
 import auth from "./authentication";
 
-beforeEach(() => flushdb());
+const db = getTestDatabase();
+
+afterAll(db.disconnect);
+
+beforeEach(db.flush);
 
 describe("Authentication middleware", () => {
   describe("with JWT", () => {

server/models/Collection.test.ts

@@ -7,13 +7,19 @@ import {
   buildTeam,
   buildDocument,
 } from "@server/test/factories";
-import { flushdb, seed } from "@server/test/support";
+import { getTestDatabase, seed } from "@server/test/support";
 import slugify from "@server/utils/slugify";
 import Collection from "./Collection";
 import Document from "./Document";
 
-beforeEach(() => flushdb());
-beforeEach(jest.resetAllMocks);
+const db = getTestDatabase();
+
+afterAll(db.disconnect);
+
+beforeEach(async () => {
+  await db.flush();
+  jest.resetAllMocks();
+});
 
 describe("#url", () => {
   test("should return correct url for the collection", () => {

server/models/Document.test.ts

@@ -6,11 +6,17 @@ import {
   buildUser,
   buildShare,
 } from "@server/test/factories";
-import { flushdb, seed } from "@server/test/support";
+import { getTestDatabase, seed } from "@server/test/support";
 import slugify from "@server/utils/slugify";
 
-beforeEach(() => flushdb());
-beforeEach(jest.resetAllMocks);
+const db = getTestDatabase();
+
+afterAll(db.disconnect);
+
+beforeEach(async () => {
+  await db.flush();
+  jest.resetAllMocks();
+});
 
 describe("#getSummary", () => {
   test("should strip markdown", async () => {