New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace Webpack with Vite #4765
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…kes the output cleaner
hanspagel
commented
Feb 13, 2023
Co-authored-by: Vio <vio@beanon.com>
tommoor
force-pushed
the
feat/replace-webpack-with-vite
branch
from
February 15, 2023 15:02
9cee5f1
to
b73cc76
Compare
A version of this is now in production, the only problem is that the paths in the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces Webpack with Vite.
Benefits
Workarounds
When using the prosemirror-math module an import from katex is broken. I worked around this with patch-package which applies Git patches to npm dependencies through a npm postinstall hook.
I’d create a PR, but the package seems to be unmaintained and I wasn’t able to solve it through configuration. If we somehow could force Vite to use the CommonJS version of prosemirror-math it would work.
The dependency
workbox-core
(used for the Service Worker) throws TypeScript exceptions and there’s no way to ignore them through the tsconfig. The only workaround I found is to enable skipLibCheck, which then skips type checking for all .d.ts files … Which is not really what we want, but solves the issue.Tasks
Testing the Service Worker
Execute the following code in the browser console and refresh the page: