Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to LLVM 17, fix linux debug build, upgrade JSC, remove some C API usages #10161

Merged
merged 34 commits into from
Apr 22, 2024

Conversation

Jarred-Sumner
Copy link
Collaborator

What does this PR do?

  • Upgrade from LLVM 16 -> LLVM 17
  • Linux debug build works once again
  • Upgrade JSC
  • Replace C API usage of JSPropertyIterator with a C++ bindings one, which also avoids cloning the property names an extra time
  • Adds a BunString version of JSValue.put which will be faster in most cases since it avoids atomizing the strings again
  • Bunch of small changes for strings for the JSC upgrade

This won't compile until the upgraded JSC successfully compiles in CI. Tested locally.

How did you verify your code works?

scripts/setup.sh Outdated Show resolved Hide resolved
Co-authored-by: Dylan Conway <35280289+dylan-conway@users.noreply.github.com>
Copy link

github-actions bot commented Apr 21, 2024

@Jarred-Sumner, your commit has failing tests :(

💪 3 failing tests Darwin AARCH64

🐧💪 6 failing tests Linux AARCH64

🐧🖥 6 failing tests Linux x64 baseline

🐧🖥 4 failing tests Linux x64

🪟💻 18 failing tests Windows x64 baseline

🪟💻 9 failing tests Windows x64

View logs

@Jarred-Sumner Jarred-Sumner marked this pull request as ready for review April 22, 2024 02:02
@Jarred-Sumner Jarred-Sumner merged commit c604c57 into main Apr 22, 2024
3 of 11 checks passed
@Jarred-Sumner Jarred-Sumner deleted the jarred/upgrade-llvm branch April 22, 2024 02:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants