feat: overhaul the crash handler #10203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
❌ @paperdave 3 files with test failures on linux-x64: |
|
❌ @paperdave 3 files with test failures on linux-x64-baseline: |
|
❌ @paperdave 2 files with test failures on bun-darwin-aarch64:
|
|
❌ @paperdave 2 files with test failures on bun-darwin-x64: |
src/bun.zig
Outdated
| @@ -1591,14 +1601,23 @@ pub fn reloadProcess( | |||
| const rc = bun.windows.TerminateProcess(@ptrFromInt(std.math.maxInt(usize)), win32.watcher_reload_exit); | |||
There was a problem hiding this comment.
Suggested change
| const rc = bun.windows.TerminateProcess(@ptrFromInt(std.math.maxInt(usize)), win32.watcher_reload_exit); | |
| const rc = bun.windows.TerminateProcess(bun.windows.GetCurrentProcess(), win32.watcher_reload_exit); |
| start_time = std.time.nanoTimestamp(); | ||
| log_ = logger.Log.init(allocator); | ||
|
|
||
| var log = &log_; | ||
|
|
||
| var panicker = MainPanicHandler.init(log); | ||
| MainPanicHandler.Singleton = &panicker; | ||
| // var panicker = MainPanicHandler.init(log); |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This deletes the existing
crash_handler.zig,panic_handler.zig,report.zig, and replaces it with a new crash handler which runs in all release builds. The primary goal of this is to allow all users to report useful crash reports to us using a "Trace String", a url-safe encoding of a stack trace or error return trace which can be demangled after the fact.The tracestrings are all URLs from the base
https://bun.report, where visiting the URL in a browser will redirect to a prompt to submit a GitHub issue, pre-filled with the remapped stack trace. Going to the homepage will show a frontend tool to just do the remapping.Bun also adds
--verbose-error-trace, which in platforms with error return traces enabled, these trace strings will be printed for any place we catch an error. This will help places we see users run into bun install errors but we don't know where it is at; We can ask them to run with the flag and share trace strings.TODOs:
bun.report--watchreload-on-crash behavior worksmainreturning an error a better experience.bun.handleErrorReturnTraceand--verbose-error-traceRevert changes intoMake Bun.unsafe.segfault private.Bun.unsafe/ changeBun.unsafe.segfaultintoBun.unsafe.crash/ remove that API entirely.Considering TODOs
I might do some more breaking changes to the format of trace-strings before the main merge. That is what I'm most worried about for now.