Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix fd offset handling in ReadStream #10883

Merged
merged 10 commits into from May 7, 2024
Merged

Fix fd offset handling in ReadStream #10883

merged 10 commits into from May 7, 2024

Conversation

gvilums
Copy link
Contributor

@gvilums gvilums commented May 7, 2024

What does this PR do?

Fixes #9907

How did you verify your code works?

Added a test

@gvilums gvilums changed the title Georgijs/stream offset Fix fd offset handling in ReadStream May 7, 2024
Copy link

github-actions bot commented May 7, 2024

Copy link
Collaborator

@Jarred-Sumner Jarred-Sumner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

One comment

@gvilums gvilums merged commit d4db29c into main May 7, 2024
@gvilums gvilums deleted the georgijs/stream-offset branch May 7, 2024 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fs.createReadStream and fs.createWriteStream from fd behaviour differs from Node
2 participants