Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add tests for #1633 #1635

Merged
merged 1 commit into from Dec 21, 2022
Merged

add tests for #1633 #1635

merged 1 commit into from Dec 21, 2022

Conversation

alexlamsl
Copy link
Contributor

@alexlamsl alexlamsl commented Dec 20, 2022 •
edited

  • setImmediate(fn, ...args)
  • setInterval(fn, delay, ...args)
  • setTimeout(fn, delay, ...args)

closes #1633

@alexlamsl alexlamsl mentioned this pull request Dec 20, 2022
Closed
@alexlamsl alexlamsl changed the title pass through arguments in timer functions add tests for #1633 Dec 20, 2022
@alexlamsl
add tests for oven-sh#1633
153620d 
- `setImmediate(fn, ...args)`
- `setInterval(fn, delay, ...args)`
- `setTimeout(fn, delay, ...args)`
@Jarred-Sumner Jarred-Sumner merged commit 06487ef into oven-sh:main Dec 21, 2022
@Jarred-Sumner
Copy link
Collaborator

Thank you

@alexlamsl alexlamsl deleted the issue-1633 branch December 21, 2022 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cannot pass extra arguments to setTimeout() & friends
2 participants
@alexlamsl @Jarred-Sumner