bugfix: performance.now function should return MS instead of nano #428

Pruxis · 2022-07-08T10:00:08Z

No description provided.

Pruxis

FinnRG · 2022-07-08T11:51:49Z

src/bun.js/bindings/ZigGlobalObject.cpp

+    double result = time / 1000000000000000.0;
    return JSValue::encode(jsNumber(time));


You are still returning the time variable. Please calculate double result = time / 1000000.0; and change jsNumber(time) to jsNumber(result)

I overlooked that, the added 0's are incorrect and should be time / 1_000_000.0 I suppose

afrokick · 2022-07-09T12:26:04Z

Maybe should add a test like expect(Math.abs(performance.now() - Date.now())).toBeCloseTo(0, 3);?

bugfix: performance.now function should return MS instead of nano

a717e2e

Pruxis commented Jul 8, 2022

View reviewed changes

FinnRG reviewed Jul 8, 2022

View reviewed changes

fix: actuality return result instead of ns time

f9e0829

Pruxis mentioned this pull request Jul 8, 2022

performance.now() is incorrect #413

Closed

Jarred-Sumner merged commit 92225fa into oven-sh:main Jul 10, 2022

Provide feedback

		double result = time / 1000000000000000.0;
		return JSValue::encode(jsNumber(time));