feat(types): Add types for node modules and various fixing #470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sno2
reviewed
Jul 9, 2022
Co-authored-by: Carter Snook <cartersnook04@gmail.com>
…o fix/update-types
Snazzah
changed the title
Snazzah
changed the title
This really shouldn't do anything differently, but it no longer hangs whenever I bundle types. Not sure if anyone else has this problem but, ehhhh...
sno2
reviewed
Jul 10, 2022
|
|
||
| for (let i = 0; i < filesToCat.length; i++) { | ||
| const name = filesToCat[i]; | ||
| fileContents.push("// " + name + "\n\n" + (await file(resolve(import.meta.dir, name)).text()) + "\n"); |
There was a problem hiding this comment.
This was intentionally loading the files in parallel instead of one at a time.
There was a problem hiding this comment.
Ah, that makes a bit more sense. Should I just revert this then?
Snazzah
changed the title
fix(types): fix types for stream, timers and util modules
2 tasks
| @@ -0,0 +1,18 @@ | |||
|
|
|||
| declare module 'tty' { | |||
There was a problem hiding this comment.
this one isn't actually implemented
we should do it, but let's not put it in types until it works
| * @see [source](https://github.com/nodejs/node/blob/v18.0.0/lib/string_decoder.js) | ||
| */ | ||
| declare module 'string_decoder' { | ||
| class StringDecoder { |
There was a problem hiding this comment.
oh man I hope nobody uses this
its going to be so slow
|
going to merge this then comment out tty one no need to keep it waiting longer |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes the following changes:
__dirnameand__filenameare now typed, but deprecated to point people to use importentries(),keys(), andvalues()are typed inHeadersstream()is typed inBlobprocess.isBunis typedAdded Module Types (listed here, mainly from @types/node)
assertassert.doesNotMatchis typed, but is not defined in the polyfillbuffertoJSON)new Buffer()andBuffer.slicebe kept?constantscryptodomaineventshttphttpsosPlatform,ArchitectureandSignals, not sure whether to have them global, put them in a NodeJS namespace or a BunJS namespaceosneeds to have a better polyfill, since none of the functions seem to give proper informationpunycodeprocessquerystringstreamstring_decodersystimersttyurlutilzlibsupports-colorMissing Buffer methods