Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Bun CLI version typo to v0.1.2 #503

Merged
merged 2 commits into from
Jul 10, 2022
Merged

Update Bun CLI version typo to v0.1.2 #503

merged 2 commits into from
Jul 10, 2022

Conversation

b0iq
Copy link
Contributor

@b0iq b0iq commented Jul 9, 2022

No description provided.

@thomwatkin
Copy link

Rather than hardcoding this you should grab the process version programmatically.

You can see an example of this at the bottom the page.

That way the version is updated every time the page is rebuilt.

https://github.com/Jarred-Sumner/bun/blob/main/packages/bun-landing/page.tsx#L815

That way you don't have to update this page on every release.

@b0iq
Copy link
Contributor Author

b0iq commented Jul 9, 2022

Rather than hardcoding this you should grab the process version programmatically.

You can see an example of this at the bottom the page.

That way the version is updated every time the page is rebuilt.

https://github.com/Jarred-Sumner/bun/blob/main/packages/bun-landing/page.tsx#L815

That way you don't have to update this page on every release.

Nice idea, but process.version already used in the footer and it showing right now 0.1.1 that's why I chose to hardcoded
However I updated it to {process.version}

@Jarred-Sumner Jarred-Sumner merged commit 85dbb9c into oven-sh:main Jul 10, 2022
@b0iq b0iq deleted the patch-1 branch July 10, 2022 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants