Fix macOS build #525
Merged
Fix macOS build #525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Running them the other way around results in a failed build.
`test/scripts` has node packages as well. If they aren't installed, then some of the tests fail to start.
One of the dependencies tries to run `cargo`, and will fail the build if it can't. The `cargo` command is provided by the `rust` brew package.
This requirement applies to _all_ macOS builds, not just those on Apple Silicon, and also had some slightly confusing wording.
This leading whitespace was making my system treat the argument as a file with name ` -L$(LLVM_PREFIX)/lib` (leading whitespace included), instead of as a library path argument.
The macOS instructions say to install `llvm@13`, which has a different path than the bare `llvm` install (`brew --prefix llvm@13` != `brew --prefix llvm`). This patch takes a slightly smarter approach: 1. If the user defined `LLVM_PREFIX` and it points to a valid path on disk, use that. 2. If `LLVM_PREFIX` is NOT a valid path, try setting it to the `llvm@13` path. 3. If it's STILL not a valid path, try the plain `llvm` path 4. If it's STILL not valid, set it to a user-friendly error. There might be a better solution for doing this, I'm not well-versed in Makefile syntax, but it's at least slightly better than it was before.
`std.math.cast` was changed in 0e6285c8fc31ff866df96847fe34e660da38b4a9. It used to throw if the cast would overflow, but now it returns `null` instead.
|
@thislooksfun I was also getting the What version of Zig did you use to compile with, and were you also getting an error in |
|
@addy I was using the latest version, 0.10.0. And yes, I did! I fixed that by running |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
I want to help with some bun development, but I ran into a few hurdles while setting up my dev environment. I figured I wouldn't be the only one, so I fixed up the problems I encountered (at least I think I fixed all of them, I might have forgotten a step I had to do), and am submitting them here!
I'm brand new to zig, and my Makefile is a bit rusty, so if you notice anything that could/should be done differently/better, please let me know!