Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): implement web interaction APIs #528

Merged
merged 4 commits into from
Jul 11, 2022

Conversation

sno2
Copy link
Collaborator

@sno2 sno2 commented Jul 10, 2022

Closes #448

Follows Deno's style for logging and (mostly) the web spec https://html.spec.whatwg.org/multipage/timers-and-user-prompts.html#simple-dialogs

src/bun.js/webcore.zig Outdated Show resolved Hide resolved
@Jarred-Sumner
Copy link
Collaborator

Jarred-Sumner commented Jul 10, 2022

A few comments but looks great overall!

@sno2 sno2 requested a review from Jarred-Sumner July 11, 2022 13:17
@Jarred-Sumner Jarred-Sumner merged commit 5fc3537 into oven-sh:main Jul 11, 2022
@sno2 sno2 deleted the feat/web-io branch July 11, 2022 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement IO-Based Web APIs (alert, confirm, prompt)
2 participants