Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

builtin -> built-in #585

Merged
merged 4 commits into from
Jul 11, 2022
Merged

builtin -> built-in #585

merged 4 commits into from
Jul 11, 2022

Conversation

boehs
Copy link
Contributor

@boehs boehs commented Jul 11, 2022

closes #584

@boehs
Copy link
Contributor Author

boehs commented Jul 11, 2022

What an embarrassing amount of mistakes for a simple change like this. If you prefer I can open a new PR to have only a single commit

@ominitay
Copy link

ominitay commented Jul 11, 2022 •
edited

Just squash it. You can either do this with an interactive rebase (git rebase -i HEAD^3), a soft reset and amend (git reset --soft HEAD^2 && git commit --amend -C HEAD), or in the GitHub interface (press the down arrow next to the close pull request button).

@boehs
Copy link
Contributor Author

boehs commented Jul 11, 2022

I believe the squash and merge option is only available for maintainers

@FinnRG FinnRG merged commit 349eb94 into oven-sh:main Jul 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FinnRG FinnRG FinnRG approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect spelling in bun.sh landing page
3 participants
@boehs @ominitay @FinnRG