-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release: v2.0 🎉 #80
base: main
Are you sure you want to change the base?
release: v2.0 🎉 #80
Conversation
* feat: add input for bun-version-file * docs: update example bun version file * [autofix.ci] apply automated fixes --------- Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Workaround for actions/toolkit#1179 Fixes #79
Hello there, I'd like to ask something: (why) is it intended that the |
I think it's because in the original pr - #76 it is meant like https://github.com/owenizedd/bum but i'll add support for .bunrc |
Oh okay, that makes sense - thanks for adding |
Why .bunrc when bunfig.toml exists? If the goal is to just specify the bun version and no further config, why not |
Sure, that sounds better, we can do that ;) |
Could it be a good idea to always check for a |
That's true but it leads to hidden behaviour and I'm not sure if that's what we want. Probably can be done by setting |
Setting it as default might make sense, though then it'd be better to check for a bun-version input first/with priority (not sure which input would override the other one right now). |
thanks for #76
Fixes #79
Fixes #81