Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release: v2.0 🎉 #80

Open
wants to merge 45 commits into
base: main
Choose a base branch
from
Open

release: v2.0 🎉 #80

wants to merge 45 commits into from

Conversation

xHyroM
Copy link
Collaborator

@xHyroM xHyroM commented May 7, 2024

thanks for #76

Fixes #79
Fixes #81

adeherysh and others added 2 commits April 12, 2024 22:17
* feat: add input for bun-version-file

* docs: update example bun version file

* [autofix.ci] apply automated fixes

---------

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
@xHyroM xHyroM changed the title release: 2.0 🎉 release: v2.0 🎉 May 7, 2024
@dloetzke
Copy link

Hello there, I'd like to ask something: (why) is it intended that the bun-version-file is called .bumrc instead of .bunrc? 🤔
Other popular projects often use their name + rc, e. g.: .eslintrc.json, .prettierrc, .nvmrc, so I believe this might just be a typo?

@xHyroM
Copy link
Collaborator Author

xHyroM commented May 20, 2024

Hello there, I'd like to ask something: (why) is it intended that the bun-version-file is called .bumrc instead of .bunrc? 🤔 Other popular projects often use their name + rc, e. g.: .eslintrc.json, .prettierrc, .nvmrc, so I believe this might just be a typo?

I think it's because in the original pr - #76 it is meant like https://github.com/owenizedd/bum but i'll add support for .bunrc

@dloetzke
Copy link

Oh okay, that makes sense - thanks for adding .bunrc as a second option then. :)

@Jarred-Sumner
Copy link
Contributor

Jarred-Sumner commented May 21, 2024

Why .bunrc when bunfig.toml exists? If the goal is to just specify the bun version and no further config, why not .bun-version instead of .bunrc?

@xHyroM
Copy link
Collaborator Author

xHyroM commented May 22, 2024

Why .bunrc when bunfig.toml exists? If the goal is to just specify the bun version and no further config, why not .bun-version instead of .bunrc?

Sure, that sounds better, we can do that ;)

@dloetzke
Copy link

Could it be a good idea to always check for a .bun-version file and use the version from there, even without any bun-version-file input being passed?
I don't think anyone would have such a file and not want the version in there to be used.

@xHyroM
Copy link
Collaborator Author

xHyroM commented May 27, 2024

Could it be a good idea to always check for a .bun-version file and use the version from there, even without any bun-version-file input being passed? I don't think anyone would have such a file and not want the version in there to be used.

That's true but it leads to hidden behaviour and I'm not sure if that's what we want. Probably can be done by setting bun-version-file to .bun-version by default

@xHyroM xHyroM linked an issue May 27, 2024 that may be closed by this pull request
@dloetzke
Copy link

That's true but it leads to hidden behaviour and I'm not sure if that's what we want. Probably can be done by setting bun-version-file to .bun-version by default

Setting it as default might make sense, though then it'd be better to check for a bun-version input first/with priority (not sure which input would override the other one right now).
That would only cause hidden behavior if there is no bun-version nor bun-version-file input, but a .bun-version file exists.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants