upgrade: replace deprecated pkg_resources with importlib, resolves #966 #977
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
regisb
requested changes
Jan 12, 2024
regisb
reviewed
Feb 2, 2024
There was a problem hiding this comment.
Awesome! Could you please just add a changelog entry? https://docs.tutor.overhang.io/tutor.html#contributing
Done. Thanks for reminding me once again. 😄 |
regisb
approved these changes
Feb 6, 2024
regisb
approved these changes
Feb 8, 2024
|
I took the liberty to cherry-pick your commit and fix conflicts. This is now closed by d99b2fe |
regisb
reviewed
Feb 9, 2024
| @@ -1,7 +1,7 @@ | |||
| # -*- mode: python -*- | |||
| import importlib | |||
| import os | |||
| import pkg_resources | |||
| from importlib_metadata | |||
There was a problem hiding this comment.
FTR, this line did cause an issue during the release. It was fixed by b69a8c7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR addresses the issue reported in Issue #966, where Tutor was facing compatibility problems with Python 3.12, particularly when using plugins. The root cause was identified as the continued use of the pkg_resources module, which is not available in Python 3.12 environments without explicit installation of setuptools.
Problem:
Solution:
Testing: