Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update fs-extra version to latest #26

Closed
overlookmotel opened this issue Apr 7, 2017 · 5 comments
Closed

Update fs-extra version to latest #26

overlookmotel opened this issue Apr 7, 2017 · 5 comments

Comments

@overlookmotel
Copy link
Owner

fs-extra used by this module is currently v0.30.0. This is now well behind - current is v2.1.2.

Need to update the dependency, but problem is that it needs checking first if any new methods have been added that need to be promisified / any sync methods that need to be excepted from promisification.

@CyberiumShadow, @andyhu, @rifler, @ReFruity you all expressed interest in the update in PR #21. Would any of you have any time to investigate.

I'm really keen to get this done, but completely tied up and not sure when I'll get to it myself.

@CyberiumShadow
Copy link

@overlookmotel Looking into it atm.

@CyberiumShadow
Copy link

@overlookmotel afaik, nothing needs to be added apart from moveSync() jprichardson/node-fs-extra#309 and jprichardson/node-fs-extra#381

walk() and walkSync() are gone from fs-extra

Other than that, that should be it

@overlookmotel
Copy link
Owner Author

@CyberiumShadow Great! Thanks for looking into that. I'll release a new version with latest fs-extra shortly.

@overlookmotel
Copy link
Owner Author

Updated fs-extra to latest in v1.0.0, just released. It is done!

@CyberiumShadow
Copy link

\o/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants