Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/pci gateway #11679

Closed
wants to merge 7 commits into from
Closed

Feat/pci gateway #11679

wants to merge 7 commits into from

Conversation

sidlynx
Copy link
Contributor

@sidlynx sidlynx commented May 13, 2024

Question Answer
Branch? feat/pci-gateway
Bug fix? yes
New feature? yes
Breaking change? yes
Tickets DTCORE-2127
License BSD 3-Clause
  • Try to keep pull requests small so they can be easily reviewed.
  • Commits are signed-off
  • Only FR translations have been updated
  • Branch is up-to-date with target branch
  • Lint has passed locally
  • Standalone app was ran and tested locally
  • Ticket reference is mentioned in linked commits (internal only)
  • Breaking change is mentioned in relevant commits

Description

Related

@github-actions github-actions bot added translation required dependencies Pull requests that update a dependency file feature New feature labels May 13, 2024
@github-actions GitHub Actions
Copy link
Contributor

yarn.lock changes

Click to toggle table visibility
Name Status Previous Current
lodash.uniqby ADDED - 4.7.0

@kqesar
feat(pci-gateway): init react app for Gateway section
9014961 
ref: DTCORE-2003

Signed-off-by: Yoann Fievez <yoann.fievez@ovhcloud.com>
@kqesar
feat(pci-gateway): add guides, title and description
72ac329 
ref: DTCORE-2008

Signed-off-by: Yoann Fievez <yoann.fievez@ovhcloud.com>
@kqesar
feat(pci-gateway): add datagrid, filter and pagination
f821b22 
ref: DTCORE-2119

Signed-off-by: Yoann Fievez <yoann.fievez@ovhcloud.com>
@kqesar
feat(pci-gateway): add action to go to private network
de36acc 
ref: DTCORE-2121

Signed-off-by: Yoann Fievez <yoann.fievez@ovhcloud.com>
@kqesar
feat(pci-gateway): add modal to delete gateway
9b4d5fb 
ref: DTCORE-2124

Signed-off-by: Yoann Fievez <yoann.fievez@ovhcloud.com>
@kqesar
feat(pci-gateway): add onboarding page
cdcae1c 
ref: DTCORE-2125

Signed-off-by: Yoann Fievez <yoann.fievez@ovhcloud.com>
@kqesar
feat(pci-gateway): add unit test for delete gateway modal
bf115ca 
ref: DTCORE-2126

Signed-off-by: Yoann Fievez <yoann.fievez@ovhcloud.com>
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented May 14, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
11.6% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@sidlynx sidlynx closed this May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file feature New feature translation required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sidlynx @kqesar