Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/pci gateway create page #11683

Closed
wants to merge 9 commits into from
Closed

Feat/pci gateway create page #11683

wants to merge 9 commits into from

Conversation

sidlynx
Copy link
Contributor

@sidlynx sidlynx commented May 13, 2024 •
edited

Question Answer
Branch? feat/pci-gateway
Bug fix? no
New feature? yes
Breaking change? yes
Tickets DTCORE-2127
License BSD 3-Clause
  • Try to keep pull requests small so they can be easily reviewed.
  • Commits are signed-off
  • Only FR translations have been updated
  • Branch is up-to-date with target branch
  • Lint has passed locally
  • Standalone app was ran and tested locally
  • Ticket reference is mentioned in linked commits (internal only)
  • Breaking change is mentioned in relevant commits

Description

Related

@github-actions github-actions bot added the has conflicts Has conflicts to resolve before merging label May 13, 2024
@sidlynx sidlynx force-pushed the feat/pci-gateway-create-page branch from 6f3f320 to 2080420 Compare May 13, 2024 07:44
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 13, 2024 •
edited

yarn.lock changes

Summary

Status Count
ADDED 1
UPDATED 12
REMOVED 2
Click to toggle table visibility
Name Status Previous Current
@types/chai REMOVED 4.3.11 -
@types/chai-subset REMOVED 1.3.5 -
@vitest/expect UPDATED 1.2.2 1.5.3
@vitest/runner UPDATED 1.2.2 1.5.3
@vitest/snapshot UPDATED 1.2.2 1.5.3
@vitest/spy UPDATED 1.2.2 1.5.3
@vitest/utils UPDATED 1.2.2 1.5.3
axios UPDATED 1.5.0 1.6.8
c8 ADDED - 9.1.0
clsx UPDATED 1.2.1 2.1.1
js-tokens UPDATED 4.0.0 9.0.0
strip-literal UPDATED 1.3.0 2.1.0
tinypool UPDATED 0.8.2 0.8.4
vite-node UPDATED 1.2.2 1.5.3
vitest UPDATED 1.2.2 1.5.3

@github-actions github-actions bot removed has conflicts Has conflicts to resolve before merging labels May 13, 2024
@sidlynx sidlynx self-assigned this May 13, 2024
@sidlynx sidlynx marked this pull request as ready for review May 13, 2024 07:59
@sidlynx sidlynx requested review from a team as code owners May 13, 2024 07:59
@sidlynx sidlynx requested review from kqesar and removed request for a team May 13, 2024 07:59
@github-actions github-actions bot added the has conflicts Has conflicts to resolve before merging label May 14, 2024
@sidlynx
feat(components): tabs component
5fb09ac 
Signed-off-by: Mohammed Hamdoune <sidlynx@gmail.com>
@sidlynx
fix(components): vitest
bf21e91 
Signed-off-by: Mohammed Hamdoune <sidlynx@gmail.com>
@sidlynx
feat(components): stepper component
78e36fe 
Signed-off-by: Mohammed Hamdoune <sidlynx@gmail.com>
@sidlynx
feat(components): use one file for vite/vitest config
05b4dcf 
Signed-off-by: Mohammed Hamdoune <sidlynx@gmail.com>
@sidlynx
feat(components): tiles input component
0176351 
Signed-off-by: Mohammed Hamdoune <sidlynx@gmail.com>
@sidlynx
fix(components): export input & tile components
568edc3 
Signed-off-by: Mohammed Hamdoune <sidlynx@gmail.com>
@sidlynx
fix(components): ignore vite tests in jest runs
7a3cc2e 
Signed-off-by: Mohammed Hamdoune <sidlynx@gmail.com>
@sidlynx sidlynx force-pushed the feat/pci-gateway-create-page branch from 652dcb5 to 04a342f Compare May 15, 2024 07:36
@github-actions github-actions bot removed the has conflicts Has conflicts to resolve before merging label May 15, 2024
@sidlynx sidlynx force-pushed the feat/pci-gateway-create-page branch from 04a342f to cbc97bf Compare May 16, 2024 08:24
@sidlynx sidlynx force-pushed the feat/pci-gateway-create-page branch from cbc97bf to ef3fdec Compare May 16, 2024 08:27
@sidlynx sidlynx force-pushed the feat/pci-gateway-create-page branch from ef3fdec to be8bd14 Compare May 16, 2024 13:00
@sidlynx sidlynx force-pushed the feat/pci-gateway-create-page branch 2 times, most recently from 2fb3c5b to 0a49b84 Compare May 16, 2024 13:14
lionel95200x
lionel95200x reviewed May 17, 2024
View reviewed changes
packages/manager/apps/pci-gateway/src/pages/add/AddGateway.page.tsx
const store = useNewGatewayStore();

useEffect(() => {
// const appName = 'public-cloud';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could your remove comment

@sidlynx
feat(pci-gateway): create page
87d7f28 
ref: DTCORE-2127

Signed-off-by: Mohammed Hamdoune <sidlynx@gmail.com>
@sidlynx sidlynx force-pushed the feat/pci-gateway-create-page branch from 0a49b84 to 87d7f28 Compare May 20, 2024 08:20
@github-actions github-actions bot added translation required has conflicts Has conflicts to resolve before merging labels May 20, 2024
@frenautvh
fix(pci-gateway): product size translation
94e93f4 
Signed-off-by: Florian Renaut <florian.renaut@corp.ovh.com>
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented May 21, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
4 Security Hotspots

See analysis details on SonarCloud

@sidlynx sidlynx closed this May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lionel95200x lionel95200x lionel95200x left review comments

@kqesar kqesar Awaiting requested review from kqesar kqesar is a code owner automatically assigned from ovh/su-digital-tools-core-stack

@frenautvh frenautvh Awaiting requested review from frenautvh frenautvh is a code owner automatically assigned from ovh/su-digital-tools-core-stack

@dectotam dectotam Awaiting requested review from dectotam dectotam is a code owner automatically assigned from ovh/team-manager-dev

@antonymarion antonymarion Awaiting requested review from antonymarion antonymarion is a code owner automatically assigned from ovh/team-manager-dev

@JacquesLarique JacquesLarique Awaiting requested review from JacquesLarique JacquesLarique is a code owner automatically assigned from ovh/team-manager-dev

Assignees

@sidlynx sidlynx

Labels
dependencies Pull requests that update a dependency file feature New feature has conflicts Has conflicts to resolve before merging translation required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@sidlynx @lionel95200x @kqesar @frenautvh