Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(public-cloud): fix localzone estimation price on block storage #11685

Merged
merged 2 commits into from
May 17, 2024
Merged

feat(public-cloud): fix localzone estimation price on block storage #11685

merged 2 commits into from
May 17, 2024

Conversation

qpavy
Copy link
Contributor

@qpavy qpavy commented May 13, 2024 •
edited

ref: MANAGER-14307

Question Answer
Branch? master
Bug fix? yes
New feature? no
Breaking change? no
Tickets Fix #MANAGER-14307
License BSD 3-Clause
  • Try to keep pull requests small so they can be easily reviewed.
  • Commits are signed-off
  • [ ] Only FR translations have been updated
  • Branch is up-to-date with target branch
  • Lint has passed locally
  • Standalone app was ran and tested locally
  • Ticket reference is mentioned in linked commits (internal only)
  • [ ] Breaking change is mentioned in relevant commits

Description

Related

@qpavy qpavy requested a review from a team as a code owner May 13, 2024 09:42
darsene
darsene previously approved these changes May 13, 2024
View reviewed changes
dectotam
dectotam previously approved these changes May 13, 2024
View reviewed changes
@qpavy qpavy changed the base branch from develop to master May 13, 2024 11:19
@qpavy qpavy dismissed stale reviews from dectotam and darsene May 13, 2024 11:19

The base branch was changed.

@qpavy qpavy requested review from a team as code owners May 13, 2024 11:19
@qpavy qpavy requested review from kqesar and frenautvh May 13, 2024 11:19
@qpavy
feat(public-cloud): fix localzone estimation price on block storage
40aef67 
ref: MANAGER-14307

Signed-off-by: Quentin Pavy <contact@quentinpavy.com>
anooparveti
anooparveti previously approved these changes May 13, 2024
View reviewed changes
ghyenne
ghyenne previously approved these changes May 13, 2024
View reviewed changes
darsene
darsene previously approved these changes May 13, 2024
View reviewed changes
dectotam
dectotam previously approved these changes May 13, 2024
View reviewed changes
@qpavy
feat(public-cloud): display volume price estimation with 3 decimals
4e9840f 
ref: MANAGER-14307

Signed-off-by: Quentin Pavy <contact@quentinpavy.com>
@qpavy qpavy dismissed stale reviews from dectotam, darsene, ghyenne, and anooparveti via 4e9840f May 15, 2024 13:45
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented May 15, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@darsene darsene changed the base branch from master to release/components-w21 May 17, 2024 07:30
@darsene darsene merged commit f2ce4b0 into release/components-w21 May 17, 2024
14 of 15 checks passed
@darsene darsene deleted the feat/MANAGER-14307 branch May 17, 2024 08:08
@darsene darsene mentioned this pull request May 17, 2024
Merged
18 tasks
sidlynx pushed a commit that referenced this pull request May 21, 2024
@qpavy @sidlynx
feat(public-cloud): fix localzone estimation price on block storage (#…
584e4e1 
…11685)

ref: MANAGER-14307

Signed-off-by: Quentin Pavy <contact@quentinpavy.com>
sidlynx pushed a commit that referenced this pull request May 21, 2024
@qpavy @sidlynx
feat(public-cloud): fix localzone estimation price on block storage (#…
fba570f 
…11685)

ref: MANAGER-14307

Signed-off-by: Quentin Pavy <contact@quentinpavy.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oalkabouss oalkabouss oalkabouss approved these changes

@anooparveti anooparveti anooparveti approved these changes

@ghyenne ghyenne ghyenne approved these changes

@darsene darsene darsene approved these changes

@dectotam dectotam dectotam left review comments

@sachinrameshn sachinrameshn Awaiting requested review from sachinrameshn sachinrameshn was automatically assigned from ovh/team-manager-dev

@kqesar kqesar Awaiting requested review from kqesar kqesar was automatically assigned from ovh/su-digital-tools-core-stack

@frenautvh frenautvh Awaiting requested review from frenautvh frenautvh was automatically assigned from ovh/su-digital-tools-core-stack

Assignees
No one assigned
Labels
feature New feature quality check: ok universe-public-cloud
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@qpavy @dectotam @oalkabouss @anooparveti @ghyenne @darsene