Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(public-cloud): add translation for next localzone regions #11686

Merged
merged 2 commits into from
May 17, 2024
Merged

feat(public-cloud): add translation for next localzone regions #11686

merged 2 commits into from
May 17, 2024

Conversation

qpavy
Copy link
Contributor

@qpavy qpavy commented May 13, 2024 •
edited

Question Answer
Branch? master
Bug fix? no
New feature? yes
Breaking change? no
Tickets Fix #MANAGER-14300
License BSD 3-Clause
  • Try to keep pull requests small so they can be easily reviewed.
  • Commits are signed-off
  • Only FR translations have been updated
  • Branch is up-to-date with target branch
  • Lint has passed locally
  • Standalone app was ran and tested locally
  • Ticket reference is mentioned in linked commits (internal only)
  • [ ] Breaking change is mentioned in relevant commits

Description

Add the translations for the next localzone region

Related

  • CMT-11818

@qpavy qpavy requested a review from a team as a code owner May 13, 2024 11:16
@qpavy qpavy changed the base branch from develop to master May 13, 2024 11:20
@qpavy qpavy requested review from a team as code owners May 13, 2024 11:20
@qpavy qpavy requested review from kqesar and frenautvh May 13, 2024 11:20
@github-actions github-actions bot added universe-telecom dependencies Pull requests that update a dependency file universe-hub container labels May 13, 2024
@qpavy
feat(public-cloud): add translation for next localzone regions
d30f360 
ref: MANAGER-14300

Signed-off-by: Quentin Pavy <contact@quentinpavy.com>
@github-actions github-actions bot removed universe-telecom dependencies Pull requests that update a dependency file universe-hub container labels May 13, 2024
anooparveti
anooparveti previously approved these changes May 13, 2024
View reviewed changes
ghyenne
ghyenne previously approved these changes May 13, 2024
View reviewed changes
@qpavy @ovh-cds
fix(i18n): add missing translations [CDS 2997]
7a7fba0 
Signed-off-by: CDS Translator Agent <opensource@ovh.net>
@antleblanc antleblanc dismissed stale reviews from ghyenne and anooparveti via 7a7fba0 May 15, 2024 07:06
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented May 15, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@darsene darsene changed the base branch from master to release/components-w21 May 17, 2024 07:45
@darsene darsene merged commit ae737b3 into release/components-w21 May 17, 2024
14 of 15 checks passed
@darsene darsene deleted the feat/MANAHER-14300 branch May 17, 2024 08:52
@darsene darsene mentioned this pull request May 17, 2024
Merged
18 tasks
darsene pushed a commit that referenced this pull request May 17, 2024
@qpavy @ovh-cds @darsene
feat(public-cloud): add translation for next localzone regions (#11686)
349b279 
ref: MANAGER-14300

Signed-off-by: Quentin Pavy <contact@quentinpavy.com>
Co-authored-by: CDS Translator Agent <opensource@ovh.net>
sidlynx pushed a commit that referenced this pull request May 21, 2024
@qpavy @ovh-cds @sidlynx
feat(public-cloud): add translation for next localzone regions (#11686)
646cdf9 
ref: MANAGER-14300

Signed-off-by: Quentin Pavy <contact@quentinpavy.com>
Co-authored-by: CDS Translator Agent <opensource@ovh.net>
sidlynx pushed a commit that referenced this pull request May 21, 2024
@qpavy @ovh-cds @sidlynx
feat(public-cloud): add translation for next localzone regions (#11686)
5945fc8 
ref: MANAGER-14300

Signed-off-by: Quentin Pavy <contact@quentinpavy.com>
Co-authored-by: CDS Translator Agent <opensource@ovh.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ghyenne ghyenne ghyenne approved these changes

@darsene darsene darsene approved these changes

@anooparveti anooparveti anooparveti left review comments

@dectotam dectotam Awaiting requested review from dectotam dectotam was automatically assigned from ovh/team-manager-dev

@antonymarion antonymarion Awaiting requested review from antonymarion antonymarion was automatically assigned from ovh/team-manager-dev

@mhelhali-soufien mhelhali-soufien Awaiting requested review from mhelhali-soufien mhelhali-soufien was automatically assigned from ovh/team-manager-dev

@kqesar kqesar Awaiting requested review from kqesar kqesar was automatically assigned from ovh/su-digital-tools-core-stack

@frenautvh frenautvh Awaiting requested review from frenautvh frenautvh was automatically assigned from ovh/su-digital-tools-core-stack

Assignees
No one assigned
Labels
feature New feature universe-bare-metal-cloud
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@qpavy @anooparveti @ghyenne @darsene