Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(pci-private-network): add onboarding page #11697

Merged
merged 1 commit into from
May 21, 2024
Merged

feat(pci-private-network): add onboarding page #11697

merged 1 commit into from
May 21, 2024

Conversation

seven-amid
Copy link
Contributor

ref: DTCORE-2201

Question Answer
Branch? feat/pci-private-network
Bug fix? no
New feature? yes
Breaking change? no
Tickets DTCORE-2201
License BSD 3-Clause
  • Try to keep pull requests small so they can be easily reviewed.
  • Commits are signed-off
  • Only FR translations have been updated
  • Branch is up-to-date with target branch
  • Lint has passed locally
  • Standalone app was ran and tested locally
  • Ticket reference is mentioned in linked commits (internal only)
  • Breaking change is mentioned in relevant commits

Description

Related

@seven-amid seven-amid requested review from a team as code owners May 13, 2024 15:10
@seven-amid seven-amid requested review from kqesar, frenautvh, antonymarion, oalkabouss and JacquesLarique and removed request for a team May 13, 2024 15:10
@github-actions github-actions bot added the has conflicts Has conflicts to resolve before merging label May 17, 2024
aboungnaseng-ovhcloud
aboungnaseng-ovhcloud reviewed May 20, 2024
View reviewed changes
packages/manager/apps/pci-private-network/src/pages/onboarding/Onboarding.page.tsx
@@ -0,0 +1,123 @@
import {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

its not possible to use onboarding page of the manager components ?

@github-actions github-actions bot added universe-public-cloud manager-components and removed has conflicts Has conflicts to resolve before merging labels May 21, 2024
feat(pci-private-network): add onboarding page
38bedba 
ref: DTCORE-2201
Signed-off-by: LIDRISSI Hamid <abdelghani-lidrissi.hamid.ext@ovhcloud.com>
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented May 21, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
30.5% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@seven-amid seven-amid merged commit 11ca5e9 into feat/pci-private-network May 21, 2024
8 of 13 checks passed
@seven-amid seven-amid deleted the feat/DTCORE-2201 branch May 21, 2024 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kqesar kqesar kqesar approved these changes

@aboungnaseng-ovhcloud aboungnaseng-ovhcloud aboungnaseng-ovhcloud approved these changes

@frenautvh frenautvh Awaiting requested review from frenautvh frenautvh is a code owner automatically assigned from ovh/su-digital-tools-core-stack

@antonymarion antonymarion Awaiting requested review from antonymarion antonymarion is a code owner automatically assigned from ovh/team-manager-dev

@oalkabouss oalkabouss Awaiting requested review from oalkabouss oalkabouss is a code owner automatically assigned from ovh/team-manager-dev

@JacquesLarique JacquesLarique Awaiting requested review from JacquesLarique JacquesLarique is a code owner automatically assigned from ovh/team-manager-dev

Assignees
No one assigned
Labels
feature New feature manager-components translation required universe-public-cloud
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@seven-amid @kqesar @aboungnaseng-ovhcloud