feat(2fa): add input files components #11698
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ref: MANAGER-14223 Signed-off-by: oalkabouss <omaralkabous@gmail.com>
oalkabouss
requested review from
sidlynx,
frenautvh,
qpavy,
ghyenne and
sachinrameshn
and removed request for
a team
chipp972
reviewed
May 14, 2024
packages/manager/apps/account-disable-2fa/src/components/FileInput/FileInput.tsx
Show resolved
Hide resolved
chipp972
reviewed
May 14, 2024
packages/manager/apps/account-disable-2fa/src/components/FileInput/FileInput.tsx
Outdated
Show resolved
Hide resolved
chipp972
reviewed
May 14, 2024
packages/manager/apps/account-disable-2fa/src/components/FileInput/FileInput.tsx
Outdated
Show resolved
Hide resolved
chipp972
reviewed
May 14, 2024
packages/manager/apps/account-disable-2fa/src/components/FileInput/FileInputErrorMessage.tsx
Outdated
Show resolved
Hide resolved
chipp972
reviewed
May 14, 2024
packages/manager/apps/account-disable-2fa/src/components/FileInput/FileInputErrorMessage.tsx
Outdated
Show resolved
Hide resolved
chipp972
reviewed
May 14, 2024
packages/manager/apps/account-disable-2fa/src/components/FileInput/FileInputList.tsx
Outdated
Show resolved
Hide resolved
chipp972
approved these changes
May 15, 2024
| </div> | ||
| ); | ||
| }; | ||
|
|
There was a problem hiding this comment.
Should we not split the file in two with each component in his own file ?
ref: MANAGER-14223 Signed-off-by: oalkabouss <omaralkabous@gmail.com>
oalkabouss
force-pushed
the
feat/MANAGER-14223
branch
from
b5c06fb
to
8eb20db
Compare
|
MaximeBajeux
approved these changes
May 15, 2024
oalkabouss
merged commit d14bfc6
into
feat/acquisition-storage-2fa
13 of 14 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: MANAGER-14223
feat/acquisition-storage-2faBreaking change is mentioned in relevant commitsDescription
Add file selection component
Related