Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(*): kms adjustments #11703

Merged
merged 1 commit into from
May 15, 2024
Merged

fix(*): kms adjustments #11703

merged 1 commit into from
May 15, 2024

Conversation

vovh
Copy link
Contributor

@vovh vovh commented May 14, 2024 •
edited

ref: MANAGER-14265

Question Answer
Branch? feat/key-management-service
Bug fix? yes
New feature? no
Breaking change? no
Tickets Fix MANAGER-14265
License BSD 3-Clause
  • Try to keep pull requests small so they can be easily reviewed.
  • Commits are signed-off
  • Only FR translations have been updated
  • Branch is up-to-date with target branch
  • Lint has passed locally
  • Standalone app was ran and tested locally
  • Ticket reference is mentioned in linked commits (internal only)
  • Breaking change is mentioned in relevant commits

Description

Related

@vovh vovh force-pushed the feat/key-management-service branch from 1c56612 to 415a228 Compare May 14, 2024 12:38
@github-actions github-actions bot added has conflicts Has conflicts to resolve before merging labels May 14, 2024
@vovh vovh force-pushed the feat/key-management-service branch 2 times, most recently from cc4333f to a1ffd47 Compare May 14, 2024 15:05
@chipp972 chipp972 force-pushed the feat/key-management-service branch from a1ffd47 to 403c833 Compare May 15, 2024 08:19
@github-actions github-actions bot removed the has conflicts Has conflicts to resolve before merging label May 15, 2024
@vovh vovh marked this pull request as ready for review May 15, 2024 13:18
@vovh vovh requested review from a team as code owners May 15, 2024 13:18
@vovh vovh requested review from sidlynx, frenautvh, antonymarion, MaximeBajeux and mhelhali-soufien and removed request for a team May 15, 2024 13:18
@vovh vovh self-assigned this May 15, 2024
@vovh vovh force-pushed the feat/key-management-service branch from eae9871 to 236ad23 Compare May 15, 2024 14:30
@vovh
fix(*): kms adjustments
fddad9a 
ref: MANAGER-14265

Signed-off-by: Vincent BONMARCHAND <vincent.bonmarchand.ext@corp.ovh.com>
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented May 15, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@vovh vovh merged commit 9a4c108 into feat/key-management-service May 15, 2024
13 of 14 checks passed
@vovh vovh deleted the feat/MANAGER-14265 branch May 15, 2024 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chipp972 chipp972 chipp972 approved these changes

@darsene darsene darsene approved these changes

@sidlynx sidlynx Awaiting requested review from sidlynx sidlynx is a code owner automatically assigned from ovh/su-digital-tools-core-stack

@frenautvh frenautvh Awaiting requested review from frenautvh frenautvh is a code owner automatically assigned from ovh/su-digital-tools-core-stack

@antonymarion antonymarion Awaiting requested review from antonymarion antonymarion is a code owner automatically assigned from ovh/team-manager-dev

@MaximeBajeux MaximeBajeux Awaiting requested review from MaximeBajeux MaximeBajeux is a code owner automatically assigned from ovh/team-manager-dev

@mhelhali-soufien mhelhali-soufien Awaiting requested review from mhelhali-soufien mhelhali-soufien is a code owner automatically assigned from ovh/team-manager-dev

Assignees

@vovh vovh

Labels
feature New feature translation required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vovh @chipp972 @darsene