Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): upgrade commander to v8.0.0 #5178

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
Expand Up @@ -51,7 +51,7 @@
"@lerna/project": "^3.21.0",
"@ovh-ux/codename-generator": "^1.0.0",
"babel-eslint": "^10.1.0",
"commander": "^6.0.0",
"commander": "^8.0.0",
"concat-stream": "^2.0.0",
"conventional-changelog-cli": "^2.0.25",
"conventional-commits-parser": "^3.0.5",
Expand Down
4 changes: 2 additions & 2 deletions packages/manager/tools/codename-generator/bin/cli.js
Expand Up @@ -14,9 +14,9 @@ program
.option('-d, --date <date>', 'date to encode', moment().format('Y-MM-DD'))
.option('-v, --verbose', 'verbose', false)
.action(() => {
const { date, seed } = program;
const { date, seed, verbose } = program.opts();
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


if (program.verbose) {
if (verbose) {
console.log('📅 date : ', date);
console.log('🎲 seed : ', seed);
}
Expand Down
2 changes: 1 addition & 1 deletion packages/manager/tools/codename-generator/package.json
Expand Up @@ -19,7 +19,7 @@
"codename-generator": "bin/cli.js"
},
"dependencies": {
"commander": "^6.0.0",
"commander": "^8.0.0",
"moment": "^2.24.0",
"shuffle-seed": "^1.1.6",
"titleize": "^2.1.0"
Expand Down
9 changes: 5 additions & 4 deletions packages/manager/tools/dev-server/bin/manager-dev-server.js
Expand Up @@ -40,8 +40,9 @@ if (program.args.length === 0) {
}

const [path] = program.args;
devServer(path, program.region, program.port, {
local2API: program.local2API,
localRegistry: program.localRegistry,
registryUrl: program.registryUrl,
const { local2API, localRegistry, port, region, registryUrl } = program.opts();
devServer(path, region, port, {
local2API,
localRegistry,
registryUrl,
});
2 changes: 1 addition & 1 deletion packages/manager/tools/dev-server/package.json
Expand Up @@ -20,7 +20,7 @@
},
"dependencies": {
"@ovh-ux/manager-dev-server-config": "^2.0.0",
"commander": "^6.0.0",
"commander": "^8.0.0",
"express": "^4.17.1",
"http-proxy-middleware": "^1.0.4"
},
Expand Down
2 changes: 1 addition & 1 deletion packages/manager/tools/registry/package.json
Expand Up @@ -26,7 +26,7 @@
},
"dependencies": {
"axios": "^0.19.2",
"commander": "^4.0.0",
"commander": "^8.0.0",
"express": "^4.17.1",
"fs-extra": "^9.0.1",
"multimatch": "^4.0.0",
Expand Down
40 changes: 21 additions & 19 deletions scripts/release.js
Expand Up @@ -50,52 +50,54 @@ program
'Force a release as patch, minor or major',
)
.action(() => {
if (!program.token) {
const options = program.opts();

if (!options.token) {
console.warn('Missing <token> option, no github release will be done!');
}
return Promise.resolve()
.then(() => (program.check ? checkChanges() : false))
.then(() => getChangedRepositories(program.force))
.then(() => (options.check ? checkChanges() : false))
.then(() => getChangedRepositories(options.force))
.then((repos) =>
bumpRepositories(
repos,
program.releaseType || null,
program.preRelease || false,
program.preId || null,
!program.noPreReleaseFileCheck || true,
options.releaseType || null,
options.preRelease || false,
options.preId || null,
!options.noPreReleaseFileCheck || true,
),
)
.then(updateChangelogs)
.then((repos) =>
getDependenciesToUpdate(repos)
.then((deps) =>
program.dependencyCheck ? checkDependencies(deps) : deps,
options.dependencyCheck ? checkDependencies(deps) : deps,
)
.then(updateDependencies)
.then(() => repos),
)
.then((repos) => {
if (program.changelog) {
writeChangelog(program.changelog, repos).then(() => repos);
if (options.changelog) {
writeChangelog(options.changelog, repos).then(() => repos);
}
return repos;
})
.then((repos) => {
if (program.release && repos.length) {
return getReleaseVersion(program.releaseName, program.seed)
if (options.release && repos.length) {
return getReleaseVersion(options.releaseName, options.seed)
.then((version) => release(version, repos))
.then((version) => {
if (program.token && program.organization) {
const options = {
draft: program.draftRelease || false,
prerelease: program.preRelease || false,
if (options.token && options.organization) {
const releaseOptions = {
draft: options.draftRelease || false,
prerelease: options.preRelease || false,
};
return releaseGithub(
program.token,
program.organization,
options.token,
options.organization,
version,
repos,
options,
releaseOptions,
);
}
return undefined;
Expand Down
17 changes: 10 additions & 7 deletions scripts/split.js
Expand Up @@ -120,8 +120,9 @@ program
'-r, --remote [remote]',
'remote url (like git@github.com:ovh-ux/manager.git)',
)
.on('--help', () => {
console.log(`
.addHelpText(
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'after',
`
Examples:

* Split a module:
Expand All @@ -135,15 +136,17 @@ Examples:

* Split a module and push it to another repository:
$ split @ovh-ux/manager-core --remote git@github.com:ovh-ux/manager.git
`);
})
`,
)
.action(() => {
const [packageName] = program.args;
const { branch, push, remote } = program.opts();

if (packageName) {
split(packageName, {
branch: program.branch || false,
push: program.push,
remote: program.remote || false,
branch: branch || false,
push,
remote: remote || false,
});
} else {
program.outputHelp();
Expand Down
12 changes: 6 additions & 6 deletions yarn.lock
Expand Up @@ -6788,21 +6788,21 @@ commander@5.1.0:
resolved "https://registry.yarnpkg.com/commander/-/commander-5.1.0.tgz#46abbd1652f8e059bddaef99bbdcb2ad9cf179ae"
integrity sha512-P0CysNDQ7rtVw4QIQtm+MRxV66vKFSvlsQvGYXZWR3qFU0jlMKHZZZgw8e+8DSah4UDKMqnknRDQz+xuQXQ/Zg==

commander@^4.0.0, commander@^4.1.1:
commander@^4.1.1:
version "4.1.1"
resolved "https://registry.yarnpkg.com/commander/-/commander-4.1.1.tgz#9fd602bd936294e9e9ef46a3f4d6964044b18068"
integrity sha512-NOKm8xhkzAjzFx8B2v5OAHT+u5pRQc2UCa2Vq9jYL/31o2wi9mxBA7LIFs3sV5VSC49z6pEhfbMULvShKj26WA==

commander@^6.0.0:
version "6.0.0"
resolved "https://registry.yarnpkg.com/commander/-/commander-6.0.0.tgz#2b270da94f8fb9014455312f829a1129dbf8887e"
integrity sha512-s7EA+hDtTYNhuXkTlhqew4txMZVdszBmKWSPEMxGr8ru8JXR7bLUFIAtPhcSuFdJQ0ILMxnJi8GkQL0yvDy/YA==

commander@^7.2.0:
version "7.2.0"
resolved "https://registry.yarnpkg.com/commander/-/commander-7.2.0.tgz#a36cb57d0b501ce108e4d20559a150a391d97ab7"
integrity sha512-QrWXB+ZQSVPmIWIhtEO9H+gwHaMGYiF5ChvoJ+K9ZGHG/sVsa6yiesAD1GC/x46sET00Xlwo1u49RVVVzvcSkw==

commander@^8.0.0:
version "8.0.0"
resolved "https://registry.yarnpkg.com/commander/-/commander-8.0.0.tgz#1da2139548caef59bd23e66d18908dfb54b02258"
integrity sha512-Xvf85aAtu6v22+E5hfVoLHqyul/jyxh91zvqk/ioJTQuJR7Z78n7H558vMPKanPSRgIEeZemT92I2g9Y8LPbSQ==

commander@~2.19.0:
version "2.19.0"
resolved "https://registry.yarnpkg.com/commander/-/commander-2.19.0.tgz#f6198aa84e5b83c46054b94ddedbfed5ee9ff12a"
Expand Down