V3 beta #64
Open
V3 beta #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EDIT use node16-strictest instead of strictest +fix npm peerDep err/downgrade TS downgrade TS to 4.6.3 Full error below: npm ERR! code ERESOLVE npm ERR! ERESOLVE could not resolve npm ERR! npm ERR! While resolving: tap@15.0.9 npm ERR! Found: typescript@4.7.0-dev.20220405 npm ERR! node_modules/typescript npm ERR! dev typescript@"^4.7.0-dev.20220405" from the root project npm ERR! npm ERR! Could not resolve dependency: npm ERR! peerOptional typescript@">=3.7.2" from tap@15.0.9 npm ERR! node_modules/tap npm ERR! dev tap@"^15.0.9" from the root project npm ERR! npm ERR! Conflicting peer dependency: typescript@4.6.3 npm ERR! node_modules/typescript npm ERR! peerOptional typescript@">=3.7.2" from tap@15.0.9 npm ERR! node_modules/tap npm ERR! dev tap@"^15.0.9" from the root project npm ERR! npm ERR! Fix the upstream dependency conflict, or retry npm ERR! this command with --force, or --legacy-peer-deps npm ERR! to accept an incorrect (and potentially broken) dependency resolution. npm ERR! npm ERR! See /Users/devinrhode2/.npm/eresolve-report.txt for a full report. npm ERR! A complete log of this run can be found in: npm ERR! /Users/devinrhode2/.npm/_logs/2022-04-05T20_58_41_431Z-debug-0.log
…include 'new'?ts(2348)"
…onsole for debug logs
not sure exactly what changed but w/e
….. didn't check every single line..
continue to use `pumpify` return type, which is most accurate
not a devDependency something seemed fishy when setting skipLibCheck: false in consuming project was getting an error that @types/pumpify should be installed
|
Re-opening, there's really no reason this PR should be closed. Even if it's too divergent to merge into master here, people should be aware it exists ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
npm run testThe diff here is very likely waaaay too big and not very useful.
The commit history, however, should prove to be very helpful in understanding all the changes.
And there are a lot of them. :)