adjustments for knex v1 and v2 #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
there is a bunch of postgres tests failing after the knex upgrade, same as in Vincit#2353 |
knex v1+ changed the return values when `.returning()` clause is used (affecting postgres), before it returned array of primitive values if only 1 column was selected to be returned (e.g. `[1]` for `.returning('id')`) but now it always returns objects (e.g. `[{ id: 1 }]` for `.returning('id')`).
Slightly reorganized `InsertOperation`, instead of calling `createModels` in `doExecute()` (right after `onRawResult` hook) and having "empty" model instances created there, possibly with undefined / declared default properties which would later overwrite input models in `InsertOperation.onAfter1`, offload the handling to `InsertOperation.onAfter1`, which now uses also `setDatabaseJson`, same as `createModels` function, to be consistent.
Additionally, adjusted `$parseDatabaseJson` in `GraphInsert` integration tests, to only parse boolean values when they are present in `json`.
related change in knex v1.0: knex/knex#4471
to make shapes of both querybuilders as close to each other as possible. Most of the methods were introduced in knex v1. - `fromRaw` - `whereLike` - `andWhereLike` - `orWhereLike` - `whereILike` - `andWhereILike` - `orWhereILike` - `withMaterialized` - `withNotMaterialized` - `jsonExtract` - `jsonSet` - `jsonInsert` - `jsonRemove` - `whereJsonObject` - `orWhereJsonObject` - `andWhereJsonObject` - `whereNotJsonObject` - `orWhereNotJsonObject` - `andWhereNotJsonObject` - `whereJsonPath` - `orWhereJsonPath` - `andWhereJsonPath` and one new `JoinBuilder` method - `andOnJsonPathEquals` (referencing knex's `JoinClause` method of the same name) `whereJson(Not)SupersetOf` / `whereJson(Not)SubsetOf` are now supported by knex >= 1.0, but for now objection handles them differently and only for postgres. Changing them to utilize knex methods directly may require a major version bump and upgrade guide. Added a test for checking JoinBuilder methods to be inline with knex's JoinClause. Fixed incorrect checking QueryBuilder methods if they are inline with knex's QueryBuilder. Added typings for new methods. Bumped knex `peerDependency` from `>=0.95.13` to `>=1.0.1` because of new methods.
falkenhawk
changed the title
flipace
approved these changes
Mar 28, 2023
There was a problem hiding this comment.
Ahoy, Captain Code-Diver! 🏊♂️
Once again, you've plunged into the abyss of an external library to unearth a fix for an issue so exotic, it could have been featured on an episode of "Rare Code Mysteries"! 🕵️♂️🔍
Your unmatched dedication to addressing the needs of the niche-est of the niche users is truly commendable. As always, your valiant efforts shall be remembered in the hallowed halls of our git history. 🏆
So, with a mixture of amusement, awe, and a pinch of "do we really need this?", I approve this PR! 🎉
May your coding trident continue to pierce the depths of the unknown! ⚓️💻
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adjustments for knex v1 and v2
knex v1+ changed the return values when
.returning()clause is used (affecting postgres), before it returned array of primitive values if only 1 column was selected to be returned (e.g.[1]for.returning('id')) but now it always returns objects (e.g.[{ id: 1 }]for.returning('id')).Slightly reorganized
InsertOperation, instead of callingcreateModelsindoExecute()(right afteronRawResulthook) and having "empty" model instances created there, possibly with undefined / declared default properties which would later overwrite input models inInsertOperation.onAfter1, offload the handling toInsertOperation.onAfter1, which now uses alsosetDatabaseJson, same ascreateModelsfunction, to be consistent.Additionally, adjusted
$parseDatabaseJsoninGraphInsertintegration tests, to only parse boolean values when they are present injson.related change in knex v1.0: knex/knex#4471
introduced new (or missing) knex querybuilder's methods
to make shapes of both querybuilders as close to each other as possible.
Most of the methods were introduced in knex v1.
fromRawwhereLikeandWhereLikeorWhereLikewhereILikeandWhereILikeorWhereILikewithMaterializedwithNotMaterializedjsonExtractjsonSetjsonInsertjsonRemovewhereJsonObjectorWhereJsonObjectandWhereJsonObjectwhereNotJsonObjectorWhereNotJsonObjectandWhereNotJsonObjectwhereJsonPathorWhereJsonPathandWhereJsonPathand one new
JoinBuildermethod -andOnJsonPathEquals(referencing knex'sJoinClausemethod of the same name)related: knex/knex#4859 knex/knex#5044
whereJson(Not)SupersetOf/whereJson(Not)SubsetOfare now supported by knex >= 1.0, but for nowobjection handles them differently and only for postgres.
Changing them to utilize knex methods directly may require a major version bump and upgrade guide.
Added a test for checking JoinBuilder methods to be inline with knex's JoinClause.
Fixed incorrect checking QueryBuilder methods if they are inline with knex's QueryBuilder.
Added typings for new methods.
Bumped knex
peerDependencyfrom>=0.95.13to>=1.0.1because of new methods.