Update to TypeScript 4.0 #560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
breck7
reviewed
Aug 21, 2020
| return { | ||
| ...commitInformation, |
There was a problem hiding this comment.
Just curious if this is just code cleanup or something new in TS?
There was a problem hiding this comment.
I'd say this is some of both.
delete is not possible in this case, so I've gone for an alternative way.
The only other real change here is that the max length is changed from 60 to 50.
breck7
approved these changes
Aug 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's not really that much new in the last few TypeScript releases, but there's
&&=,??=and such now, and also some performance improvements, including faster startup times in VS Code.Only few fixes were needed in our code.
The only drawback right now is that
ts-jestcurrently complains that it's running with an unsupported version of TS, but that's fixed already, just not released yet. We can upgrade it soon to get rid of the warning.