Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs-only] add client protocol overview #3816

Merged
merged 1 commit into from May 18, 2022
Merged

Conversation

butonic
Copy link
Member

@butonic butonic commented May 17, 2022

@dragotin @mmattel I wanted to get this off my uncommited doc / diagram list. Might be worth a blog post to go into the detail of what clients can expect and what the payload of these requests and responses looks like.

The proxy is left out as it only forwards requests to specific storage providers. We could use example urls with different hosts to indicate that the spaces can be located on different hosts.

I would like to add a sequence diagram for what happens on the server side as well, but this should be a starting point for client developers ... hm we coulvd add examples below it ... and link to https://owncloud.dev/libre-graph-api/#/me.drives/ListMyDrives

@update-docs
Copy link

update-docs bot commented May 17, 2022

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@mmattel
Copy link
Contributor

mmattel commented May 17, 2022

Can you add "somewhere" a remark with a link to https://mermaid.liveBecause if docs would like to reuse the image created, it is benificial to know where to do 😄

@butonic butonic changed the title add client protocol overview [docs-only] add client protocol overview May 17, 2022
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
@mmattel
Copy link
Contributor

mmattel commented May 18, 2022

Just for the record, mermaid.live has a bug when creating an svg image which I identified when working on the admin docs. I filed an issue there, see: mermaid-js/mermaid-live-editor#796

Copy link
Contributor

@mmattel mmattel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mmattel mmattel merged commit afb5d41 into master May 18, 2022
@delete-merged-branch delete-merged-branch bot deleted the doc-client-protocol branch May 18, 2022 13:52
ownclouders pushed a commit that referenced this pull request May 18, 2022
Merge: 523f56c b893a81
Author: Martin <github@diemattels.at>
Date:   Wed May 18 15:52:34 2022 +0200

    Merge pull request #3816 from owncloud/doc-client-protocol

    [docs-only] add client protocol overview
@butonic butonic added this to In progress in Infinite Scale Team Board via automation May 19, 2022
@butonic butonic moved this from In progress to Done in Infinite Scale Team Board May 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants