-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs-only] enhancement(docs): first draft of the activities service adr #9187
Conversation
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
|
||
### Activity store | ||
|
||
* Use a go-micro store to store the individual activities. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you stick to the ADR template and keep one headline per option?
Mabe make two ADRs one for store and one for format?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can u explain what you mean, its a bit unclear to us?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or maybe even three ADRs: one for store, one for format, one for API.
* Activities should be stored in a way that they can be queried efficiently. | ||
* Activities should stay in place event if the resource is gone. | ||
* Activities reflect the state at a given point in time and not the current state. | ||
* The Service should only store a configurable number of activities per resource. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the story behind this statement? Usually I want to have all activity since the beginning of the universe.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We were worried about amount of data store. But this limit can be deactivated if you have eternal space on your harddrive.
## Pros and Cons of the Options <!-- optional --> | ||
|
||
* Activity store: | ||
* (PRO) Introducing a new database type might be more efficient for storing activities. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this a PRO
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Its a PRO
for using another database
|
||
### Activity store | ||
|
||
* Use a go-micro store to store the individual activities. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or maybe even three ADRs: one for store, one for format, one for API.
feat(adr): Review suggestions Co-authored-by: Benedikt Kulmann <benedikt@kulmann.biz>
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Happy to get it merged in this state. ADR status is draft
anyway. Thanks for working on this!
[docs-only] enhancement(docs): first draft of the activities service adr
Adds ADR for the new activities service, please add your thoughts below.
Fixes #9075