Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests-only][full-ci] removing the usage of a stepdef inside another stepdef in Sharing.php #9189

Merged
merged 1 commit into from
May 22, 2024

Conversation

ishabaral
Copy link
Contributor

Description

removing the use of a stepdefinition inside another stepdefinition in Sharing.php

Related Issue

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:locally
  • test case 2:ci

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

tests/acceptance/features/bootstrap/Sharing.php Outdated Show resolved Hide resolved
tests/acceptance/features/bootstrap/Sharing.php Outdated Show resolved Hide resolved
tests/acceptance/features/bootstrap/Sharing.php Outdated Show resolved Hide resolved
tests/acceptance/features/bootstrap/Sharing.php Outdated Show resolved Hide resolved
tests/acceptance/features/bootstrap/Sharing.php Outdated Show resolved Hide resolved
@ishabaral ishabaral force-pushed the sharing branch 2 times, most recently from 40e27dd to 549e3a7 Compare May 21, 2024 04:23
@ishabaral ishabaral requested a review from saw-jan May 21, 2024 04:54
tests/acceptance/features/bootstrap/Sharing.php Outdated Show resolved Hide resolved
tests/acceptance/features/bootstrap/Sharing.php Outdated Show resolved Hide resolved
tests/acceptance/features/bootstrap/Sharing.php Outdated Show resolved Hide resolved
tests/acceptance/features/bootstrap/Sharing.php Outdated Show resolved Hide resolved
tests/acceptance/features/bootstrap/Sharing.php Outdated Show resolved Hide resolved
tests/acceptance/features/bootstrap/Sharing.php Outdated Show resolved Hide resolved
@ishabaral ishabaral force-pushed the sharing branch 3 times, most recently from ff120ac to a964f57 Compare May 22, 2024 10:21
Copy link

sonarcloud bot commented May 22, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@ishabaral ishabaral requested a review from saw-jan May 22, 2024 11:13
@saw-jan saw-jan merged commit 228eb68 into owncloud:master May 22, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants