Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests-only] [full-ci] Use sharingNG in coreApiShareOperationsToShares2 #9191

Merged
merged 3 commits into from
May 20, 2024
Merged

[tests-only] [full-ci] Use sharingNG in coreApiShareOperationsToShares2 #9191

merged 3 commits into from
May 20, 2024

Conversation

Salipa-Gurung
Copy link
Contributor

@Salipa-Gurung Salipa-Gurung commented May 16, 2024 •
edited

Description

Changed Given step for sharing using SharingNg in coreApiShareOperationsToShares2:

  1. getWebDAVSharePermissions.feature
  2. shareAccessByID.feature

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@Salipa-Gurung Salipa-Gurung self-assigned this May 16, 2024
@Salipa-Gurung Salipa-Gurung force-pushed the use-sharingNG-in-coreApiShareOperationsToShares2 branch from 3a2a5d4 to 61a2e2c Compare May 16, 2024 11:29
@Salipa-Gurung Salipa-Gurung mentioned this pull request May 16, 2024
Closed
@Salipa-Gurung Salipa-Gurung force-pushed the use-sharingNG-in-coreApiShareOperationsToShares2 branch 4 times, most recently from b96285e to 396a080 Compare May 20, 2024 03:45
@Salipa-Gurung Salipa-Gurung force-pushed the use-sharingNG-in-coreApiShareOperationsToShares2 branch from 396a080 to d36a52d Compare May 20, 2024 05:05
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented May 20, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@Salipa-Gurung Salipa-Gurung marked this pull request as ready for review May 20, 2024 05:46
grgprarup
grgprarup approved these changes May 20, 2024
View reviewed changes
Copy link
Contributor

@grgprarup grgprarup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@grgprarup grgprarup merged commit fa2ddd8 into master May 20, 2024
4 checks passed
@delete-merged-branch delete-merged-branch bot deleted the use-sharingNG-in-coreApiShareOperationsToShares2 branch May 20, 2024 06:53
ownclouders pushed a commit that referenced this pull request May 20, 2024
@grgprarup
Merge pull request #9191 from owncloud/use-sharingNG-in-coreApiShareO…
0445c95 
…perationsToShares2

[tests-only] [full-ci] Use sharingNG in coreApiShareOperationsToShares2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grgprarup grgprarup grgprarup approved these changes

@saw-jan saw-jan Awaiting requested review from saw-jan

@S-Panta S-Panta Awaiting requested review from S-Panta

Assignees

@Salipa-Gurung Salipa-Gurung

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Salipa-Gurung @grgprarup