Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests-only][full-ci] adding skip-on-reva tag for test related to sharing link #9200

Merged
merged 1 commit into from
May 24, 2024

Conversation

S-Panta
Copy link
Contributor

@S-Panta S-Panta commented May 17, 2024

Description

skipping test on reva related to created link share as graph is not implemented in Reva edge.

Reva edge bump: cs3org/reva#4682

How Has This Been Tested?

  • test environment:
  • locally
  • CI

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@S-Panta S-Panta self-assigned this May 17, 2024
@S-Panta S-Panta force-pushed the fix-reva branch 2 times, most recently from c81ef45 to 9e086b7 Compare May 20, 2024 03:55
@S-Panta S-Panta marked this pull request as ready for review May 20, 2024 04:29
@S-Panta S-Panta changed the title [tests-only][full-ci]fixing reva error [tests-only][full-ci adding skip-on-reva tag for test related to sharing link May 20, 2024
@S-Panta S-Panta force-pushed the fix-reva branch 5 times, most recently from 2a927c7 to 2cb3385 Compare May 20, 2024 08:53
@S-Panta S-Panta force-pushed the fix-reva branch 2 times, most recently from 1b10185 to c2f51e0 Compare May 22, 2024 08:30
@S-Panta S-Panta changed the title [tests-only][full-ci adding skip-on-reva tag for test related to sharing link [tests-only][full-ci] adding skip-on-reva tag for test related to sharing link May 22, 2024
@S-Panta S-Panta force-pushed the fix-reva branch 2 times, most recently from 44c8246 to d31d86b Compare May 22, 2024 10:50
Copy link

sonarcloud bot commented May 24, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@S-Panta S-Panta requested a review from grgprarup May 24, 2024 04:17
Copy link
Member

@saw-jan saw-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

You can remove @skipOnRevaMaster and then merge the example tables and @skipOnReva tag from scenarios.

@S-Panta please, state if you wish to do it in this PR or not

@saw-jan saw-jan merged commit 83374e5 into master May 24, 2024
4 checks passed
@delete-merged-branch delete-merged-branch bot deleted the fix-reva branch May 24, 2024 05:49
@saw-jan
Copy link
Member

saw-jan commented May 24, 2024

please, state if you wish to do it in this PR or not

@S-Panta do follow up in another PR

ownclouders pushed a commit that referenced this pull request May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants