Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[full-ci] [tests-only] Use sharing-ng in given steps for sharing #9202

Merged
merged 5 commits into from
May 20, 2024
Merged

[full-ci] [tests-only] Use sharing-ng in given steps for sharing #9202

merged 5 commits into from
May 20, 2024

Conversation

grgprarup
Copy link
Contributor

Description

Used sharingNG graph API in the given steps for sharing.

Suites covered:

  • coreApiSharePublicLink2/
    • copyFromPublicLink.feature
    • multilinkSharing.feature
    • updatePublicLinkShare.feature
    • uploadToPublicLinkShare.feature

Related Issue

How Has This Been Tested?

  • Locally
  • 🤖

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

This was referenced May 17, 2024
Closed
Closed
@grgprarup grgprarup force-pushed the use-sharingNG-in-given-steps-coreApiSharePublicLink2 branch from d6ba934 to 8992392 Compare May 17, 2024 08:27
@grgprarup grgprarup self-assigned this May 17, 2024
@grgprarup grgprarup force-pushed the use-sharingNG-in-given-steps-coreApiSharePublicLink2 branch 3 times, most recently from 8334483 to 7100ee2 Compare May 17, 2024 11:29
@grgprarup grgprarup force-pushed the use-sharingNG-in-given-steps-coreApiSharePublicLink2 branch from 7100ee2 to b2de566 Compare May 20, 2024 03:42
saw-jan
saw-jan approved these changes May 20, 2024
View reviewed changes
Copy link
Member

@saw-jan saw-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@grgprarup grgprarup enabled auto-merge May 20, 2024 04:17
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented May 20, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@grgprarup grgprarup merged commit 25b7c7c into master May 20, 2024
4 checks passed
@delete-merged-branch delete-merged-branch bot deleted the use-sharingNG-in-given-steps-coreApiSharePublicLink2 branch May 20, 2024 04:38
ownclouders pushed a commit that referenced this pull request May 20, 2024
@grgprarup
Merge pull request #9202 from owncloud/use-sharingNG-in-given-steps-c…
deabeca 
…oreApiSharePublicLink2

[full-ci] [tests-only] Use sharing-ng in given steps for sharing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saw-jan saw-jan saw-jan approved these changes

@SagarGi SagarGi Awaiting requested review from SagarGi

@Salipa-Gurung Salipa-Gurung Awaiting requested review from Salipa-Gurung

@amrita-shrestha amrita-shrestha Awaiting requested review from amrita-shrestha

@S-Panta S-Panta Awaiting requested review from S-Panta

@PrajwolAmatya PrajwolAmatya Awaiting requested review from PrajwolAmatya

@nirajacharya2 nirajacharya2 Awaiting requested review from nirajacharya2

Assignees

@grgprarup grgprarup

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@grgprarup @saw-jan @nirajacharya2