Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[full-ci] [tests-only] Use sharing-ng in given steps for sharing #9206

Merged

Conversation

grgprarup
Copy link
Contributor

Description

Used sharingNG graph API in the given steps for sharing.

Suites covered:

  • coreApiWebdavPreviews/
    • previews.feature

Related Issue

How Has This Been Tested?

  • Locally
  • 🤖

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@grgprarup grgprarup self-assigned this May 17, 2024
@grgprarup grgprarup force-pushed the use-sharingNG-in-given-steps-coreApiWebdavPreviews branch 2 times, most recently from 07fc2ca to 483955e Compare May 20, 2024 10:36
@grgprarup grgprarup requested review from saw-jan and S-Panta May 20, 2024 10:36
@grgprarup grgprarup marked this pull request as ready for review May 20, 2024 10:36
@@ -134,12 +134,17 @@ Feature: previews of files downloaded through the webdav API
| new |
| spaces |

@skipOnReva
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tag is added for the whole feature file at the top.

@grgprarup grgprarup force-pushed the use-sharingNG-in-given-steps-coreApiWebdavPreviews branch from 483955e to bdef851 Compare May 20, 2024 11:16
@grgprarup grgprarup force-pushed the use-sharingNG-in-given-steps-coreApiWebdavPreviews branch from bdef851 to 1a3f44f Compare May 21, 2024 03:11
@grgprarup grgprarup enabled auto-merge May 21, 2024 03:18
Copy link

sonarcloud bot commented May 21, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@grgprarup grgprarup merged commit 11b8de2 into master May 21, 2024
4 checks passed
@delete-merged-branch delete-merged-branch bot deleted the use-sharingNG-in-given-steps-coreApiWebdavPreviews branch May 21, 2024 03:46
ownclouders pushed a commit that referenced this pull request May 21, 2024
…oreApiWebdavPreviews

[full-ci] [tests-only] Use sharing-ng in given steps for sharing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants