Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[full-ci] [tests-only] Use sharing-ng in given steps for sharing #9207

Merged
merged 2 commits into from
May 20, 2024
Merged

[full-ci] [tests-only] Use sharing-ng in given steps for sharing #9207

merged 2 commits into from
May 20, 2024

Conversation

grgprarup
Copy link
Contributor

Description

Used sharingNG graph API in the given steps for sharing.

Suites covered:

  • coreApiWebdavOperations/
    • listFiles.feature
    • propfind.feature

Related Issue

How Has This Been Tested?

  • Locally
  • 🤖

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@grgprarup grgprarup self-assigned this May 17, 2024
@grgprarup grgprarup mentioned this pull request May 17, 2024
Closed
@grgprarup grgprarup force-pushed the use-sharingNG-in-given-steps-coreApiWebdavOperations branch from 42748f5 to 5b5f64e Compare May 17, 2024 11:35
@grgprarup grgprarup force-pushed the use-sharingNG-in-given-steps-coreApiWebdavOperations branch from 5b5f64e to 8717959 Compare May 20, 2024 10:05
@grgprarup grgprarup requested review from S-Panta and saw-jan May 20, 2024 10:09
@grgprarup grgprarup marked this pull request as ready for review May 20, 2024 10:09
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented May 20, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

S-Panta
S-Panta approved these changes May 20, 2024
View reviewed changes
Copy link
Contributor

@S-Panta S-Panta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@grgprarup grgprarup merged commit 0edb7ff into master May 20, 2024
4 checks passed
@delete-merged-branch delete-merged-branch bot deleted the use-sharingNG-in-given-steps-coreApiWebdavOperations branch May 20, 2024 10:34
ownclouders pushed a commit that referenced this pull request May 20, 2024
@grgprarup
Merge pull request #9207 from owncloud/use-sharingNG-in-given-steps-c…
f002127 
…oreApiWebdavOperations

[full-ci] [tests-only] Use sharing-ng in given steps for sharing
ownclouders pushed a commit that referenced this pull request May 21, 2024
@grgprarup
Merge pull request #9207 from owncloud/use-sharingNG-in-given-steps-c…
47d3585 
…oreApiWebdavOperations

[full-ci] [tests-only] Use sharing-ng in given steps for sharing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@S-Panta S-Panta S-Panta approved these changes

@saw-jan saw-jan Awaiting requested review from saw-jan

@Salipa-Gurung Salipa-Gurung Awaiting requested review from Salipa-Gurung

@nabim777 nabim777 Awaiting requested review from nabim777

Assignees

@grgprarup grgprarup

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@grgprarup @S-Panta