[full-ci] Vue 2.7 #7877
Merged
[full-ci] Vue 2.7 #7877
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![renovate[bot]](https://avatars.githubusercontent.com/in/2740?s=60&v=4){kind=small}
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
|
This at least needs |
renovate
bot
force-pushed
the
renovate/vue-monorepo
branch
2 times, most recently
from
06a7791
to
c32e0f6
Compare
dschmidt
force-pushed
the
renovate/vue-monorepo
branch
2 times, most recently
from
dcff70b
to
0191c11
Compare
10 tasks
|
I've updated the After doing that the (unit) test suite looks fairly okay already: I expect this to go down quite a bit already after |
dschmidt
force-pushed
the
renovate/vue-monorepo
branch
from
0191c11
to
986b61b
Compare
dschmidt
force-pushed
the
renovate/vue-monorepo
branch
2 times, most recently
from
795783c
to
f81d795
Compare
dschmidt
changed the title
dschmidt
changed the title
|
Results for oCISSharingPerm2 https://drone.owncloud.com/owncloud/web/29770/66/1 💥 The acceptance tests failed on retry. Please find the screenshots inside ...
webUISharingFilePermissionMultipleUsers-shareFileWithMultipleUsers_feature-L47.pngwebUISharingFilePermissionMultipleUsers-shareFileWithMultipleUsers_feature-L48.pngwebUISharingFilePermissionMultipleUsers-shareFileWithMultipleUsers_feature-L49.pngwebUISharingFilePermissionMultipleUsers-shareFileWithMultipleUsers_feature-L50.pngwebUISharingFilePermissionMultipleUsers-shareFileWithMultipleUsers_feature-L51.pngwebUISharingFilePermissionMultipleUsers-shareFileWithMultipleUsers_feature-L52.pngwebUISharingFilePermissionsGroups-sharePermissionsGroup_feature-L54.pngwebUISharingFilePermissionsGroups-sharePermissionsGroup_feature-L55.pngwebUISharingFilePermissionsGroups-sharePermissionsGroup_feature-L56.pngwebUISharingFilePermissionsGroups-sharePermissionsGroup_feature-L57.pngwebUISharingFilePermissionsGroups-sharePermissionsGroup_feature-L58.pngwebUISharingFilePermissionsGroups-sharePermissionsGroup_feature-L59.pngwebUISharingFolderAdvancedPermissionMultipleUsers-sharedFolderWithMultipleUsersAdvancedPermissions_feature-L47.pngwebUISharingFolderAdvancedPermissionMultipleUsers-sharedFolderWithMultipleUsersAdvancedPermissions_feature-L48.pngwebUISharingFolderAdvancedPermissionMultipleUsers-sharedFolderWithMultipleUsersAdvancedPermissions_feature-L49.pngwebUISharingFolderAdvancedPermissionMultipleUsers-sharedFolderWithMultipleUsersAdvancedPermissions_feature-L50.pngwebUISharingFolderAdvancedPermissionMultipleUsers-sharedFolderWithMultipleUsersAdvancedPermissions_feature-L51.pngwebUISharingFolderAdvancedPermissionMultipleUsers-sharedFolderWithMultipleUsersAdvancedPermissions_feature-L52.pngwebUISharingFolderAdvancedPermissionMultipleUsers-sharedFolderWithMultipleUsersAdvancedPermissions_feature-L53.pngwebUISharingFolderAdvancedPermissionMultipleUsers-sharedFolderWithMultipleUsersAdvancedPermissions_feature-L54.pngwebUISharingFolderAdvancedPermissionMultipleUsers-sharedFolderWithMultipleUsersAdvancedPermissions_feature-L55.pngwebUISharingFolderAdvancedPermissionMultipleUsers-sharedFolderWithMultipleUsersAdvancedPermissions_feature-L56.pngwebUISharingFolderAdvancedPermissionMultipleUsers-sharedFolderWithMultipleUsersAdvancedPermissions_feature-L57.pngwebUISharingFolderAdvancedPermissionMultipleUsers-sharedFolderWithMultipleUsersAdvancedPermissions_feature-L58.pngwebUISharingFolderAdvancedPermissionsGroups-shareAdvancePermissionsGroup_feature-L54.pngwebUISharingFolderAdvancedPermissionsGroups-shareAdvancePermissionsGroup_feature-L55.pngwebUISharingFolderAdvancedPermissionsGroups-shareAdvancePermissionsGroup_feature-L56.pngwebUISharingFolderAdvancedPermissionsGroups-shareAdvancePermissionsGroup_feature-L57.pngwebUISharingFolderAdvancedPermissionsGroups-shareAdvancePermissionsGroup_feature-L58.pngwebUISharingFolderAdvancedPermissionsGroups-shareAdvancePermissionsGroup_feature-L59.pngwebUISharingFolderAdvancedPermissionsGroups-shareAdvancePermissionsGroup_feature-L60.pngwebUISharingFolderAdvancedPermissionsGroups-shareAdvancePermissionsGroup_feature-L61.pngwebUISharingFolderAdvancedPermissionsGroups-shareAdvancePermissionsGroup_feature-L62.pngwebUISharingFolderAdvancedPermissionsGroups-shareAdvancePermissionsGroup_feature-L63.pngwebUISharingFolderAdvancedPermissionsGroups-shareAdvancePermissionsGroup_feature-L64.pngwebUISharingFolderAdvancedPermissionsGroups-shareAdvancePermissionsGroup_feature-L65.pngwebUISharingFolderPermissionMultipleUsers-shareFolderWithMultipleUsers_feature-L48.pngwebUISharingFolderPermissionMultipleUsers-shareFolderWithMultipleUsers_feature-L49.pngwebUISharingFolderPermissionMultipleUsers-shareFolderWithMultipleUsers_feature-L50.pngwebUISharingFolderPermissionMultipleUsers-shareFolderWithMultipleUsers_feature-L51.pngwebUISharingFolderPermissionMultipleUsers-shareFolderWithMultipleUsers_feature-L52.pngwebUISharingFolderPermissionMultipleUsers-shareFolderWithMultipleUsers_feature-L53.png |
dschmidt
force-pushed
the
renovate/vue-monorepo
branch
from
de17cb0
to
9ad7c26
Compare
dschmidt
force-pushed
the
renovate/vue-monorepo
branch
4 times, most recently
from
cf7458c
to
d00b84e
Compare
JammingBen
reviewed
Nov 14, 2022
packages/web-app-files/src/components/SideBar/Shares/Collaborators/RoleDropdown.vue
Show resolved
Hide resolved
dschmidt
force-pushed
the
renovate/vue-monorepo
branch
from
0c1d0e4
to
d00b84e
Compare
kulmann
force-pushed
the
renovate/vue-monorepo
branch
from
4f345c2
to
554723c
Compare
|
SonarCloud Quality Gate failed. |
| import { queryItemAsString, useAppDefaults, useRouteQuery } from 'web-pkg/src/composables' | ||
| import { defineComponent } from '@vue/composition-api' | ||
| import { defineComponent } from 'vue' |
There was a problem hiding this comment.
Could be united with line 39, no? 🥷 Not worth an individual commit though, was just browsing and spotted this. Awesome work btw!
kulmann
approved these changes
Nov 15, 2022
| @@ -53,8 +48,12 @@ export default defineComponent({ | |||
| const store = useStore() | |||
| const sharesLoading = computed(() => store.getters['Files/sharesTreeLoading']) | |||
|
|
|||
| const { incomingParentShare, ...rest } = useIncomingParentShare() | |||
There was a problem hiding this comment.
Not so happy with var name rest, but also don't have a better idea... 🤔
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
2.6.14->2.7.14Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Renovate will not automatically rebase this PR, because other commits have been found.
🔕 Ignore: Close this PR and you won't be reminded about these updates again.
This PR has been generated by Mend Renovate. View repository job log here.