Replace Sass @import usage with @forward #105
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The use of @import is discouraged. Utilize the @use rule instead. See: <https://sass-lang.com/documentation/at-rules/import> "The Sass team discourages the continued use of the @import rule. Sass will gradually phase it out over the next few years, and eventually remove it from the language entirely. Prefer the @use rule instead." Changelog: * Removed extraeneous $color-text comments from scss/css files * Implemented @use over @import * scss/_main.scss defaults to the Sakura base theme * In turn, scss/sakura.scss does not specify overrides * Updated test.html to include missing themes * Also added padding to theme switcher labels * Updated README 'earthy' theme example * Updated package-lock.json version 3 (latest stable node/npm) * Reference versions: node 18.14.0 (LTS) / npm 9.3.1
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
rmkane
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The use of @import is discouraged. Utilize the @use rule instead.
See: https://sass-lang.com/documentation/at-rules/import
Changelog
$color-textcomments from scss/css files@useover@importscss/_main.scssdefaults to the Sakura base themescss/sakura.scssdoes not specify overridespackage-lock.jsonversion 3 (latest stable node/npm)