New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate to package.json/tsconfig.json crates #99

Merged

Boshen merged 9 commits into oxc-project:main from milesj:jsts

Mar 6, 2024

Contributor

milesj commented Feb 29, 2024

This PR migrates to the https://crates.io/crates/nodejs_package_json and https://crates.io/crates/typescript_tsconfig_json crates, that'll be used by Rolldown and other tools in the future. Better to standardize on common shapes, instead of duplicating over and over again.

For actually changes, will leave them as comments in the PR.

milesj commented

View reviewed changes

napi/src/options.rs Outdated Show resolved Hide resolved

milesj commented

View reviewed changes

src/lib.rs Show resolved Hide resolved

milesj commented

View reviewed changes

src/options.rs Outdated Show resolved Hide resolved

milesj commented

View reviewed changes

src/package_json.rs Show resolved Hide resolved

milesj commented

View reviewed changes

src/package_json.rs Show resolved Hide resolved

milesj commented

View reviewed changes

src/package_json.rs Show resolved Hide resolved

milesj commented

View reviewed changes

src/package_json.rs Show resolved Hide resolved

milesj commented

View reviewed changes

src/package_json.rs Show resolved Hide resolved

milesj commented

View reviewed changes

src/package_json.rs Show resolved Hide resolved

milesj commented

View reviewed changes

src/package_json.rs Show resolved Hide resolved

milesj commented

View reviewed changes

src/tsconfig.rs Show resolved Hide resolved

milesj commented

View reviewed changes

src/tsconfig.rs Show resolved Hide resolved

milesj commented

View reviewed changes

src/tsconfig.rs Show resolved Hide resolved

milesj commented

View reviewed changes

src/tsconfig.rs Show resolved Hide resolved

codspeed-hq bot commented Mar 1, 2024 •

edited

CodSpeed Performance Report

Merging #99 will not alter performance

_{Comparing milesj:jsts (6af6b62) with main (eb6ada0)}

Summary

✅ 2 untouched benchmarks

Boshen reviewed

View reviewed changes

src/lib.rs Show resolved Hide resolved

src/lib.rs Outdated Show resolved Hide resolved

src/package_json.rs Outdated Show resolved Hide resolved

ematipico reviewed

View reviewed changes

src/options.rs Outdated Show resolved Hide resolved

milesj added 7 commits

March 4, 2024 15:05


          Update tsconfig.

29e9615


          Fix extend.

52050a8


          Remove debugs.

d9e93fd


          Update fields type.

9a718c3


          Update impl.

4e709f1


          Add memory option.

2fe89cd


          Polish.

cc422b9

milesj force-pushed the jsts branch from 9cb68d6 to cc422b9 Compare

March 4, 2024 23:18

Contributor Author

milesj commented Mar 4, 2024

@Boshen @ematipico Made some changes. I have some more ideas to take this further if need be.

Member

Boshen commented Mar 5, 2024

I'll test this in Rspack before merging.

Boshen added 2 commits

March 6, 2024 16:16


          update

d0f0653


          update

6af6b62

Boshen approved these changes

View reviewed changes

Boshen enabled auto-merge (squash)

March 6, 2024 08:22

Boshen merged commit 290ebce into oxc-project:main

17 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment