Skip to content

Commit

Permalink
feat(linter): support check ImportNamespaceSpecifier in no_import_assign
Browse files Browse the repository at this point in the history
  • Loading branch information
@Dunqing
Dunqing committed Mar 6, 2024
1 parent f498d0d commit 7831b21
Show file tree
Hide file tree
Showing 3 changed files with 476 additions and 16 deletions.
61 changes: 45 additions & 16 deletions crates/oxc_linter/src/rules/eslint/no_import_assign.rs
View file
@@ -1,10 +1,12 @@
use oxc_ast::AstKind;
use oxc_diagnostics::{
miette::{self, Diagnostic},
thiserror::Error,
};
use oxc_macros::declare_oxc_lint;
use oxc_semantic::SymbolId;
use oxc_span::Span;
use oxc_span::{GetSpan, Span};
use oxc_syntax::operator::UnaryOperator;

use crate::{context::LintContext, rule::Rule};

Expand Down Expand Up @@ -46,7 +48,35 @@ impl Rule for NoImportAssign {
fn run_on_symbol(&self, symbol_id: SymbolId, ctx: &LintContext<'_>) {
let symbol_table = ctx.semantic().symbols();
if symbol_table.get_flag(symbol_id).is_import_binding() {
let kind = ctx.nodes().kind(symbol_table.get_declaration(symbol_id));
let is_namespace_specifier = matches!(kind, AstKind::ImportNamespaceSpecifier(_));
for reference in symbol_table.get_resolved_references(symbol_id) {
if is_namespace_specifier {
let Some(parent_node) = ctx.nodes().parent_node(reference.node_id()) else {
return;
};
if let AstKind::MemberExpression(expr) = parent_node.kind() {
let Some(parent_parent_node) = ctx.nodes().parent_node(parent_node.id())
else {
return;
};
let is_unary_expression_with_delete_operator = |kind| matches!(kind, AstKind::UnaryExpression(expr) if expr.operator == UnaryOperator::Delete);
let parent_parent_kind = parent_parent_node.kind();
if matches!(parent_parent_kind, AstKind::SimpleAssignmentTarget(_))
// delete namespace.module
|| is_unary_expression_with_delete_operator(parent_parent_kind)
// delete namespace?.module
|| matches!(parent_parent_kind, AstKind::ChainExpression(_) if ctx.nodes().parent_kind(parent_parent_node.id()).is_some_and(is_unary_expression_with_delete_operator))
{
if let Some((span, _)) = expr.static_property_info() {
if span != reference.span() {
return ctx.diagnostic(NoImportAssignDiagnostic(expr.span()));
}
}
}
}
}

if reference.is_write() {
ctx.diagnostic(NoImportAssignDiagnostic(reference.span()));
}
Expand Down Expand Up @@ -154,19 +184,18 @@ fn test() {
("import * as mod9 from 'mod'; ({ bar: mod9 } = foo)", None),
("import * as mod10 from 'mod'; ({ bar: mod10 = 0 } = foo)", None),
("import * as mod11 from 'mod'; ({ ...mod11 } = foo)", None),
// TODO
// ("import * as mod1 from 'mod'; mod1.named = 0", None),
// ("import * as mod2 from 'mod'; mod2.named += 0", None),
// ("import * as mod3 from 'mod'; mod3.named++", None),
// ("import * as mod4 from 'mod'; for (mod4.named in foo);", None),
// ("import * as mod5 from 'mod'; for (mod5.named of foo);", None),
// ("import * as mod6 from 'mod'; [mod6.named] = foo", None),
// ("import * as mod7 from 'mod'; [mod7.named = 0] = foo", None),
// ("import * as mod8 from 'mod'; [...mod8.named] = foo", None),
// ("import * as mod9 from 'mod'; ({ bar: mod9.named } = foo)", None),
// ("import * as mod10 from 'mod'; ({ bar: mod10.named = 0 } = foo)", None),
// ("import * as mod11 from 'mod'; ({ ...mod11.named } = foo)", None),
// ("import * as mod12 from 'mod'; delete mod12.named", None),
("import * as mod1 from 'mod'; mod1.named = 0", None),
("import * as mod2 from 'mod'; mod2.named += 0", None),
("import * as mod3 from 'mod'; mod3.named++", None),
("import * as mod4 from 'mod'; for (mod4.named in foo);", None),
("import * as mod5 from 'mod'; for (mod5.named of foo);", None),
("import * as mod6 from 'mod'; [mod6.named] = foo", None),
("import * as mod7 from 'mod'; [mod7.named = 0] = foo", None),
("import * as mod8 from 'mod'; [...mod8.named] = foo", None),
("import * as mod9 from 'mod'; ({ bar: mod9.named } = foo)", None),
("import * as mod10 from 'mod'; ({ bar: mod10.named = 0 } = foo)", None),
("import * as mod11 from 'mod'; ({ ...mod11.named } = foo)", None),
("import * as mod12 from 'mod'; delete mod12.named", None),
// ("import * as mod from 'mod'; Object.assign(mod, obj)", None),
// ("import * as mod from 'mod'; Object.defineProperty(mod, key, d)", None),
// ("import * as mod from 'mod'; Object.defineProperties(mod, d)", None),
Expand All @@ -176,10 +205,10 @@ fn test() {
// ("import * as mod from 'mod'; Reflect.deleteProperty(mod, key)", None),
// ("import * as mod from 'mod'; Reflect.set(mod, key, value)", None),
// ("import * as mod from 'mod'; Reflect.setPrototypeOf(mod, proto)", None),
// ("import mod, * as mod_ns from 'mod'; mod.prop = 0; mod_ns.prop = 0", None),
("import mod, * as mod_ns from 'mod'; mod.prop = 0; mod_ns.prop = 0", None),
// ("import * as mod from 'mod'; Object?.defineProperty(mod, key, d)", None),
// ("import * as mod from 'mod'; (Object?.defineProperty)(mod, key, d)", None),
// ("import * as mod from 'mod'; delete mod?.prop", None),
("import * as mod from 'mod'; delete mod?.prop", None),
];

Tester::new(NoImportAssign::NAME, pass, fail).test_and_snapshot();
Expand Down
91 changes: 91 additions & 0 deletions crates/oxc_linter/src/snapshots/no_import_assign.snap
View file
Expand Up @@ -239,3 +239,94 @@ expression: no_import_assign
· ─────
╰────
help: imported bindings are readonly

⚠ eslint(no-import-assign): do not assign to imported bindings
╭─[no_import_assign.tsx:1:30]
1 │ import * as mod1 from 'mod'; mod1.named = 0
· ──────────
╰────
help: imported bindings are readonly

⚠ eslint(no-import-assign): do not assign to imported bindings
╭─[no_import_assign.tsx:1:30]
1 │ import * as mod2 from 'mod'; mod2.named += 0
· ──────────
╰────
help: imported bindings are readonly

⚠ eslint(no-import-assign): do not assign to imported bindings
╭─[no_import_assign.tsx:1:30]
1 │ import * as mod3 from 'mod'; mod3.named++
· ──────────
╰────
help: imported bindings are readonly

⚠ eslint(no-import-assign): do not assign to imported bindings
╭─[no_import_assign.tsx:1:35]
1 │ import * as mod4 from 'mod'; for (mod4.named in foo);
· ──────────
╰────
help: imported bindings are readonly

⚠ eslint(no-import-assign): do not assign to imported bindings
╭─[no_import_assign.tsx:1:35]
1 │ import * as mod5 from 'mod'; for (mod5.named of foo);
· ──────────
╰────
help: imported bindings are readonly

⚠ eslint(no-import-assign): do not assign to imported bindings
╭─[no_import_assign.tsx:1:31]
1 │ import * as mod6 from 'mod'; [mod6.named] = foo
· ──────────
╰────
help: imported bindings are readonly

⚠ eslint(no-import-assign): do not assign to imported bindings
╭─[no_import_assign.tsx:1:31]
1 │ import * as mod7 from 'mod'; [mod7.named = 0] = foo
· ──────────
╰────
help: imported bindings are readonly

⚠ eslint(no-import-assign): do not assign to imported bindings
╭─[no_import_assign.tsx:1:34]
1 │ import * as mod8 from 'mod'; [...mod8.named] = foo
· ──────────
╰────
help: imported bindings are readonly

⚠ eslint(no-import-assign): do not assign to imported bindings
╭─[no_import_assign.tsx:1:38]
1 │ import * as mod9 from 'mod'; ({ bar: mod9.named } = foo)
· ──────────
╰────
help: imported bindings are readonly

⚠ eslint(no-import-assign): do not assign to imported bindings
╭─[no_import_assign.tsx:1:39]
1 │ import * as mod10 from 'mod'; ({ bar: mod10.named = 0 } = foo)
· ───────────
╰────
help: imported bindings are readonly

⚠ eslint(no-import-assign): do not assign to imported bindings
╭─[no_import_assign.tsx:1:37]
1 │ import * as mod11 from 'mod'; ({ ...mod11.named } = foo)
· ───────────
╰────
help: imported bindings are readonly

⚠ eslint(no-import-assign): do not assign to imported bindings
╭─[no_import_assign.tsx:1:38]
1 │ import * as mod12 from 'mod'; delete mod12.named
· ───────────
╰────
help: imported bindings are readonly

⚠ eslint(no-import-assign): do not assign to imported bindings
╭─[no_import_assign.tsx:1:51]
1 │ import mod, * as mod_ns from 'mod'; mod.prop = 0; mod_ns.prop = 0
· ───────────
╰────
help: imported bindings are readonly

0 comments on commit 7831b21

Please sign in to comment.