Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(semantic): move redeclare varaibles to symbol table #2614

Merged
merged 1 commit into from Mar 6, 2024
Merged

feat(semantic): move redeclare varaibles to symbol table #2614

merged 1 commit into from Mar 6, 2024

Conversation

Dunqing
Copy link
Member

@Dunqing Dunqing commented Mar 5, 2024 •
edited

close: #2219

@Dunqing Graphite App
Copy link
Member Author

Dunqing commented Mar 5, 2024 •
edited

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @Dunqing and the rest of your teammates on Graphite Graphite

@Dunqing Dunqing mentioned this pull request Mar 5, 2024
Merged
@github-actions github-actions bot added A-linter Area - Linter A-semantic Area - Semantic labels Mar 5, 2024
@Dunqing Dunqing force-pushed the 03-05-feat_semantic_move_redeclare_varaibles_to_symbol_table branch 2 times, most recently from bb7a88d to e1ba6c7 Compare March 5, 2024 11:56
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Mar 5, 2024 •
edited

CodSpeed Performance Report

Merging #2614 will not alter performance

Comparing 03-05-feat_semantic_move_redeclare_varaibles_to_symbol_table (b31e7a6) with main (8001b2f)

Summary

✅ 29 untouched benchmarks

@Dunqing Dunqing force-pushed the 03-05-feat_semantic_move_redeclare_varaibles_to_symbol_table branch from e1ba6c7 to c509242 Compare March 5, 2024 12:06
@Dunqing Dunqing mentioned this pull request Mar 5, 2024
Merged
@Boshen
Copy link
Member

Boshen commented Mar 6, 2024

@Dunqing Need a quick rebase

@Dunqing Dunqing force-pushed the 03-05-feat_semantic_move_redeclare_varaibles_to_symbol_table branch from c509242 to b31e7a6 Compare March 6, 2024 04:34
@Boshen Boshen merged commit 57ce737 into main Mar 6, 2024
23 checks passed
@Boshen Boshen deleted the 03-05-feat_semantic_move_redeclare_varaibles_to_symbol_table branch March 6, 2024 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
A-linter Area - Linter A-semantic Area - Semantic
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Symbol missing redeclare variable information
2 participants
@Dunqing @Boshen