feat(task): init eslint-plugin-tree-shaking rule #2662
Merged
+733
−39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @mysteryven and the rest of your teammates on |
mysteryven
force-pushed
the
03-10-feat_task_init_eslint-plugin-tree-shaking_rule
branch
from
a7e5ed0
to
1c39e64
Compare
CodSpeed Performance ReportMerging #2662 will not alter performanceComparing Summary
|
mysteryven
force-pushed
the
03-10-feat_task_init_eslint-plugin-tree-shaking_rule
branch
from
1c39e64
to
bfade28
Compare
mysteryven
force-pushed
the
03-10-feat_task_init_eslint-plugin-tree-shaking_rule
branch
from
bfade28
to
9047964
Compare
Dunqing
requested changes
Mar 10, 2024
There was a problem hiding this comment.
I think we should put this file in the new PR.
There was a problem hiding this comment.
This is fine, let's merge and iterate.
Boshen
approved these changes
Mar 10, 2024
| @@ -117,6 +117,9 @@ new-react-perf-rule name: | |||
| new-n-rule name: | |||
| cargo run -p rulegen {{name}} n | |||
|
|
|||
| new-tree-shaking-rule name: | |||
There was a problem hiding this comment.
We don't need this, there is only one rule.
There was a problem hiding this comment.
This is fine, let's merge and iterate.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.