Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(linter/import): support check reexport binding in namespace #2678

Conversation

Dunqing
Copy link
Member

@Dunqing Dunqing commented Mar 11, 2024

No description provided.

Copy link
Member Author

Dunqing commented Mar 11, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @Dunqing and the rest of your teammates on Graphite Graphite

@github-actions github-actions bot added the A-linter Area - Linter label Mar 11, 2024
Copy link

codspeed-hq bot commented Mar 11, 2024

CodSpeed Performance Report

Merging #2678 will not alter performance

Comparing 03-11-feat_linter/import_support_check_reexport_binding_in_namespace (f431c96) with main (366a879)

Summary

✅ 29 untouched benchmarks

Copy link
Member

@Boshen Boshen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should add reexported bindings inside the linter service instead of doing a very expensive lookup here.

@Dunqing
Copy link
Member Author

Dunqing commented Mar 11, 2024

I think we should add reexported bindings inside the linter service instead of doing a very expensive lookup here.

Can you explain what I have to do? I don't quite understand add reexported bindings inside the linter service

@Dunqing Dunqing force-pushed the 03-11-feat_linter/import_support_check_reexport_binding_in_namespace branch from 82ffbb2 to f431c96 Compare March 11, 2024 15:02
@Boshen Boshen merged commit e86cd62 into main Mar 12, 2024
23 checks passed
@Boshen Boshen deleted the 03-11-feat_linter/import_support_check_reexport_binding_in_namespace branch March 12, 2024 05:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-linter Area - Linter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants