Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(linter/import): check ObjectPattern syntax in namespace #2691

Merged
merged 1 commit into from Mar 18, 2024
Merged

feat(linter/import): check ObjectPattern syntax in namespace #2691

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
49 changes: 28 additions & 21 deletions crates/oxc_linter/src/rules/import/namespace.rs
View file
Open in desktop
@@ -1,4 +1,4 @@
use oxc_ast::AstKind;
use oxc_ast::{ast::BindingPatternKind, AstKind};
use oxc_diagnostics::{
miette::{self, Diagnostic},
thiserror::Error,
Expand Down Expand Up @@ -109,14 +109,23 @@ impl Rule for Namespace {
check_binding_exported(name, span);
}
}

AstKind::JSXMemberExpressionObject(_) => {
if let Some(AstKind::JSXMemberExpression(expr)) =
ctx.nodes().parent_kind(node.id())
{
check_binding_exported(&expr.property.name, expr.property.span);
}
}
AstKind::VariableDeclarator(decl) => {
let BindingPatternKind::ObjectPattern(pattern) = &decl.id.kind else {
return;
};
pattern.properties.iter().for_each(|property| {
if let Some(name) = property.key.name() {
check_binding_exported(&name, property.key.span());
}
});
}
_ => {}
}
}
Expand Down Expand Up @@ -144,30 +153,28 @@ fn test() {
// console.log(foo.Qux1);
// console.log(foo.Qux2);"#,
r"import * as foo from './common';",
// r#"import * as names from "./named-exports"; const { a } = names"#,
// r#"import * as names from "./named-exports"; const { d: c } = names"#,
// r#"import * as names from "./named-exports";
r#"import * as names from "./named-exports"; const { a } = names"#,
r#"import * as names from "./named-exports"; const { d: c } = names"#,
r#"import * as names from "./named-exports";
// const { c } = foo,
// { length } = "names",
// alt = names;"#,
// r#"import * as names from "./named-exports"; const { ExportedClass: { length } } = names"#,
// r#"import * as names from "./named-exports"; function b(names) { const { c } = names }"#,
// r#"import * as names from "./named-exports"; function b() { let names = null; const { c } = names }"#,
// r#"import * as names from "./named-exports"; const x = function names() { const { c } = names }"#,
// r#"export * as names from "./named-exports""#,
// r#"export defport, * as names from "./named-exports""#,
r#"import * as names from "./named-exports"; const { ExportedClass: { length } } = names"#,
r#"import * as names from "./named-exports"; function b(names) { const { c } = names }"#,
r#"import * as names from "./named-exports"; function b() { let names = null; const { c } = names }"#,
r#"import * as names from "./named-exports"; const x = function names() { const { c } = names }"#,
r#"export * as names from "./named-exports""#,
// r#"export * as names from "./does-not-exist""#,
// r#"import * as Endpoints from "./issue-195/Endpoints"; console.log(Endpoints.Users)"#,
// r#"function x() { console.log((names.b).c); } import * as names from "./named-exports";"#,
r#"function x() { console.log((names.b).c); } import * as names from "./named-exports";"#,
// r#"import * as names from './default-export';"#,
// r#"import * as names from './default-export'; console.log(names.default)"#,
// r#"export * as names from "./default-export""#,
// r#"export defport, * as names from "./default-export""#,
// r#"import * as names from './named-exports'; console.log(names['a']);"#,
// r#"import * as names from './named-exports'; const {a, b, ...rest} = names;"#,
// r#"import * as names from './named-exports'; const {a, b, ...rest} = names;"#,
// r#"import * as ns from './re-export-common'; const {foo} = ns;"#,
// r#"import * as Names from "./named-exports"; const Foo = <Names.a/>"#,
// r"import * as names from './named-exports'; console.log(names['a']);",
r"import * as names from './named-exports'; const {a, b, ...rest} = names;",
r"import * as ns from './re-export-common'; const {foo} = ns;",
r#"import * as Names from "./named-exports"; const Foo = <Names.a/>"#,
// r#"import * as foo from "./typescript-declare-nested"
// foo.bar.MyFunction()"#,
// r#"import { foobar } from "./typescript-declare-interface""#,
Expand Down Expand Up @@ -220,10 +227,10 @@ fn test() {
r"import * as names from './named-exports'; console.log(names['a']);",
r"import * as foo from './bar'; foo.foo = 'y';",
r"import * as foo from './bar'; foo.x = 'y';",
// r#"import * as names from "./named-exports"; const { c } = names"#,
// r#"import * as names from "./named-exports"; function b() { const { c } = names }"#,
// r#"import * as names from "./named-exports"; const { c: d } = names"#,
// r#"import * as names from "./named-exports"; const { c: { d } } = names"#,
r#"import * as names from "./named-exports"; const { c } = names"#,
r#"import * as names from "./named-exports"; function b() { const { c } = names }"#,
r#"import * as names from "./named-exports"; const { c: d } = names"#,
r#"import * as names from "./named-exports"; const { c: { d } } = names"#,
// r#"import * as Endpoints from "./issue-195/Endpoints"; console.log(Endpoints.Foo)"#,
// r#"import * as namespace from './malformed.js';"#,
// r#"import b from './deep/default'; console.log(b.e)"#,
Expand Down
24 changes: 24 additions & 0 deletions crates/oxc_linter/src/snapshots/namespace.snap
View file
Open in desktop
Expand Up @@ -33,6 +33,30 @@ expression: namespace
· ─
╰────

⚠ eslint-plugin-import(namespace): "c" not found in imported namespace "./named-exports".
╭─[index.js:1:51]
1 │ import * as names from "./named-exports"; const { c } = names
· ─
╰────

⚠ eslint-plugin-import(namespace): "c" not found in imported namespace "./named-exports".
╭─[index.js:1:66]
1 │ import * as names from "./named-exports"; function b() { const { c } = names }
· ─
╰────

⚠ eslint-plugin-import(namespace): "c" not found in imported namespace "./named-exports".
╭─[index.js:1:51]
1 │ import * as names from "./named-exports"; const { c: d } = names
· ─
╰────

⚠ eslint-plugin-import(namespace): "c" not found in imported namespace "./named-exports".
╭─[index.js:1:51]
1 │ import * as names from "./named-exports"; const { c: { d } } = names
· ─
╰────

⚠ eslint-plugin-import(namespace): "c" not found in imported namespace "./named-exports".
╭─[index.js:1:19]
1 │ console.log(names.c); import * as names from './named-exports';
Expand Down