Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(prettier/ts): better conformance #2721

Merged
merged 6 commits into from Mar 20, 2024

Conversation

LIMPIX31
Copy link
Contributor

@LIMPIX31 LIMPIX31 commented Mar 14, 2024

I know 5% isn't much, but it's small steps like this that move us toward our goal.

@github-actions github-actions bot added the A-prettier Area - Prettier label Mar 14, 2024
@LIMPIX31 LIMPIX31 force-pushed the 03-14-feat_prettier_conformance branch from 4def191 to 5396cb7 Compare March 19, 2024 15:16
Copy link

codspeed-hq bot commented Mar 19, 2024

CodSpeed Performance Report

Merging #2721 will not alter performance

Comparing LIMPIX31:03-14-feat_prettier_conformance (ccc4932) with main (99dcd00)

Summary

✅ 29 untouched benchmarks

🆕 5 new benchmarks

Benchmarks breakdown

Benchmark main LIMPIX31:03-14-feat_prettier_conformance Change
🆕 parser_napi[RadixUIAdoptionSection.jsx] N/A 240.7 µs N/A
🆕 parser_napi[antd.js] N/A 529.9 ms N/A
🆕 parser_napi[cal.com.tsx] N/A 119.7 ms N/A
🆕 parser_napi[checker.ts] N/A 242.5 ms N/A
🆕 parser_napi[pdf.mjs] N/A 74.4 ms N/A

Copy link
Member

@Boshen Boshen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@Boshen
Copy link
Member

Boshen commented Mar 20, 2024

Prettier conformance test is failling :-(

@LIMPIX31
Copy link
Contributor Author

LIMPIX31 commented Mar 20, 2024

Prettier conformance test is failling :-(

I'm not quite sure why (
I thought that was to be expected.

@Dunqing
Copy link
Member

Dunqing commented Mar 20, 2024

Prettier conformance test is failling :-(

I'm not quite sure why ( I thought that was to be expected.

Yes, it is expected, but you need to update the snap. Let's run just coverage in your local and push the changes.

@Dunqing Dunqing merged commit 1721fee into oxc-project:main Mar 20, 2024
30 checks passed
@LIMPIX31 LIMPIX31 deleted the 03-14-feat_prettier_conformance branch March 20, 2024 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-prettier Area - Prettier
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants