Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(napi): pass comments to JS as JSON #2725

Conversation

overlookmotel
Copy link
Collaborator

No description provided.

Copy link
Collaborator Author

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @overlookmotel and the rest of your teammates on Graphite Graphite

Copy link

codspeed-hq bot commented Mar 15, 2024

CodSpeed Performance Report

Merging #2725 will not alter performance

Comparing 03-15-perf_napi_pass_comments_to_JS_as_JSON (d84d757) with 03-15-chore_napi_add_oxc-parser_to_benchmarks (a2ee4ee)

🎉 Hooray! codspeed-rust just leveled up to 2.4.0!

A heads-up, this is a breaking change and it might affect your current performance baseline a bit. But here's the exciting part - it's packed with new, cool features and promises improved result stability 🥳!
Curious about what's new? Visit our releases page to delve into all the awesome details about this new version.

Summary

✅ 34 untouched benchmarks

@overlookmotel
Copy link
Collaborator Author

I'm surprised. This doesn't make any difference.

@Boshen Boshen deleted the 03-15-perf_napi_pass_comments_to_JS_as_JSON branch March 25, 2024 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant