Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(napi): remove oxc-parser from benchmarks #2738

Merged
merged 1 commit into from Mar 16, 2024

Conversation

overlookmotel
Copy link
Collaborator

@overlookmotel overlookmotel commented Mar 16, 2024

#2724 added CodSpeed benchmarks for NodeJS oxc-parser.

Unfortunately it turns out CodSpeed's results are wildly inaccurate. Unclear why, but have raised an issue with CodSpeed (CodSpeedHQ/action#96). In meantime it seems best to remove the benchmarks as they're not useful at present.

Copy link
Collaborator Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @overlookmotel and the rest of your teammates on Graphite Graphite

Copy link

codspeed-hq bot commented Mar 16, 2024

CodSpeed Performance Report

Merging #2738 will not alter performance

Comparing 03-16-chore_napi_remove_oxc-parser_from_benchmarks (4ad77a2) with main (57bf985)

Summary

✅ 29 untouched benchmarks

⁉️ 5 dropped benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main 03-16-chore_napi_remove_oxc-parser_from_benchmarks Change
⁉️ parser(napi)[RadixUIAdoptionSection.jsx] 6.3 ms N/A N/A
⁉️ parser(napi)[antd.js] 15.4 s N/A N/A
⁉️ parser(napi)[cal.com.tsx] 4 s N/A N/A
⁉️ parser(napi)[checker.ts] 6.7 s N/A N/A
⁉️ parser(napi)[pdf.mjs] 2.5 s N/A N/A

@Boshen Boshen merged commit 78f1adc into main Mar 16, 2024
5 of 6 checks passed
@Boshen Boshen deleted the 03-16-chore_napi_remove_oxc-parser_from_benchmarks branch March 16, 2024 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants