Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(linter): eslint/max-params #2749

Merged
merged 6 commits into from Mar 19, 2024
Merged

feat(linter): eslint/max-params #2749

merged 6 commits into from Mar 19, 2024

Conversation

JoSeBu1
Copy link
Contributor

@JoSeBu1 JoSeBu1 commented Mar 17, 2024

Rule detail: https://eslint.org/docs/latest/rules/max-params

Maybe I can add function name, I was searching for it, but I don't know how to get it.

@github-actions github-actions bot added the A-linter Area - Linter label Mar 17, 2024
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Mar 17, 2024 •
edited

CodSpeed Performance Report

Merging #2749 will not alter performance

Comparing JoSeBu1:feat/max-params (2a04f23) with main (5edd196)

Summary

✅ 29 untouched benchmarks

mysteryven
mysteryven approved these changes Mar 19, 2024
View reviewed changes
Copy link
Member

@mysteryven mysteryven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@mysteryven mysteryven merged commit 86d006e into oxc-project:main Mar 19, 2024
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dunqing Dunqing Dunqing left review comments

@mysteryven mysteryven mysteryven approved these changes

Assignees
No one assigned
Labels
A-linter Area - Linter
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@JoSeBu1 @Dunqing @mysteryven