Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tasks): benchmark NodeJS parser #2770

Merged
merged 1 commit into from Mar 20, 2024

Conversation

overlookmotel
Copy link
Collaborator

@overlookmotel overlookmotel commented Mar 20, 2024

Add NodeJS parser to benchmarks.

Previous attempt #2724 did not work due CodSpeed producing very inaccurate results (CodSpeedHQ/action#96).

This version runs the actual benchmarks without CodSpeed's instrumentation. Then another faux-benchmark runs within Codspeed's instrumented action and just performs meaningless calculations in a loop for as long as is required to take same amount of time as the original uninstrumented benchmarks took.

It's unfortunate that we therefore don't get flame graphs on CodSpeed, but this seems to be the best we can do for now.

Copy link

codspeed-hq bot commented Mar 20, 2024

CodSpeed Performance Report

Merging #2770 will not alter performance

Comparing overlookmotel:napi-benchmark2 (a26c09d) with main (1c07a99)

Summary

✅ 29 untouched benchmarks

🆕 5 new benchmarks

Benchmarks breakdown

Benchmark main overlookmotel:napi-benchmark2 Change
🆕 parser_napi[RadixUIAdoptionSection.jsx] N/A 239.8 µs N/A
🆕 parser_napi[antd.js] N/A 538.8 ms N/A
🆕 parser_napi[cal.com.tsx] N/A 122.8 ms N/A
🆕 parser_napi[checker.ts] N/A 244.2 ms N/A
🆕 parser_napi[pdf.mjs] N/A 75.8 ms N/A

@overlookmotel overlookmotel merged commit 5080913 into oxc-project:main Mar 20, 2024
29 checks passed
@overlookmotel overlookmotel deleted the napi-benchmark2 branch March 20, 2024 05:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant