Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(semantic): distinguish type imports in ModuleRecord #2785

Merged
merged 1 commit into from Mar 23, 2024
Merged

feat(semantic): distinguish type imports in ModuleRecord #2785

merged 1 commit into from Mar 23, 2024

Conversation

Dunqing
Copy link
Member

@Dunqing Dunqing commented Mar 22, 2024 •
edited

I am not sure moving ImportOrExportKind to oxc-syntax is a good solution.

@Dunqing Graphite App
Copy link
Member Author

Dunqing commented Mar 22, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @Dunqing and the rest of your teammates on Graphite Graphite

@github-actions github-actions bot added A-parser Area - Parser A-semantic Area - Semantic A-ast Area - AST labels Mar 22, 2024
@Dunqing Dunqing force-pushed the 03-22-feat_semantic_distinguish_type_imports_in_ModuleRecord branch from c138169 to 6113ba4 Compare March 22, 2024 03:31
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Mar 22, 2024 •
edited

CodSpeed Performance Report

Merging #2785 will not alter performance

Comparing 03-22-feat_semantic_distinguish_type_imports_in_ModuleRecord (04aa32c) with main (4a42c5f)

Summary

✅ 34 untouched benchmarks

@Dunqing Dunqing force-pushed the 03-22-feat_semantic_distinguish_type_imports_in_ModuleRecord branch from 6113ba4 to 1d9cac8 Compare March 22, 2024 03:39
@Boshen
Copy link
Member

Boshen commented Mar 22, 2024

Feels weird.

Do we really need an enum here in module record or do we just need a simple boolean is_type?

@Dunqing
Copy link
Member Author

Dunqing commented Mar 23, 2024

We just need a simple boolean. I like is_type

@Dunqing Dunqing force-pushed the 03-22-feat_semantic_distinguish_type_imports_in_ModuleRecord branch from 1d9cac8 to 04aa32c Compare March 23, 2024 03:22
@Boshen Boshen merged commit 712b3d2 into main Mar 23, 2024
32 checks passed
@Boshen Boshen deleted the 03-22-feat_semantic_distinguish_type_imports_in_ModuleRecord branch March 23, 2024 13:38
charnog pushed a commit to charnog/oxc that referenced this pull request Mar 26, 2024
@Dunqing @charnog
feat(semantic): distinguish type imports in ModuleRecord (oxc-project…
d0e8179 
…#2785)

I am not sure moving `ImportOrExportKind` to `oxc-syntax` is a good
solution.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
A-ast Area - AST A-parser Area - Parser A-semantic Area - Semantic
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Dunqing @Boshen