Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(transformer/typescript): remove verbatim_module_syntax option #2796

Conversation

Dunqing
Copy link
Member

@Dunqing Dunqing commented Mar 24, 2024

Remove verbatim_module_syntax option, Because Babel's onlyRemoveTypeImports option same behavior with verbatim_module_syntax , You can see babel/babel#15493 (comment)

Copy link
Member Author

Dunqing commented Mar 24, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @Dunqing and the rest of your teammates on Graphite Graphite

@github-actions github-actions bot added the A-transformer Area - Transformer / Transpiler label Mar 24, 2024
@Dunqing
Copy link
Member Author

Dunqing commented Mar 24, 2024

@rzvxa cc

Copy link

codspeed-hq bot commented Mar 24, 2024

CodSpeed Performance Report

Merging #2796 will not alter performance

Comparing 03-24-feat_transformer/typescript_remove_verbatim_module_syntax_option (ad18009) with main (813226b)

Summary

✅ 34 untouched benchmarks

@rzvxa
Copy link
Collaborator

rzvxa commented Mar 24, 2024

@Dunqing Well it is great, I think we should move on with this. It is always possible to add an alias to the cli so we can set this flag with either option.

@rzvxa
Copy link
Collaborator

rzvxa commented Mar 24, 2024

I'll resolve the discussion on #2794, I commented there before seeing this PR.

@Dunqing
Copy link
Member Author

Dunqing commented Mar 24, 2024

It is always possible to add an alias to the client so we can set this flag with either option.

Sorry, I don't get your mean. Can you explain this?

@rzvxa
Copy link
Collaborator

rzvxa commented Mar 24, 2024

It is always possible to add an alias to the client so we can set this flag with either option.

Sorry, I don't get your mean. Can you explain this?

Yeah sure, Sorry I didn't make my assumptions clear, Let me try to rephrase it.

Since verbatim_module_syntax and only_remove_type_imports are doing basically the same thing we can have an alias for them, So no matter which option is passed to the oxc we always set the only_remove_type_imports since it has an easier and more clear name in my opinion.

Remember that I'm not 100% sure these 2 are supposed to do the same thing since the verbatim_module_syntax can mean more things in the future.

@Boshen Boshen merged commit 398a034 into main Mar 24, 2024
32 checks passed
@Boshen Boshen deleted the 03-24-feat_transformer/typescript_remove_verbatim_module_syntax_option branch March 24, 2024 20:51
charnog pushed a commit to charnog/oxc that referenced this pull request Mar 26, 2024
…xc-project#2796)

Remove `verbatim_module_syntax` option, Because Babel's
[onlyRemoveTypeImports](https://babeljs.io/docs/babel-plugin-transform-typescript#onlyremovetypeimports)
option same behavior with `verbatim_module_syntax` , You can see
babel/babel#15493 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-transformer Area - Transformer / Transpiler
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants